Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: ios/chrome/browser/passwords/credential_manager.mm

Issue 2592653003: Avoid use-after-free in FormFetcherImpl (Closed)
Patch Set: Posting CMPFM method instead of the delegate method Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/credential_manager.mm
diff --git a/ios/chrome/browser/passwords/credential_manager.mm b/ios/chrome/browser/passwords/credential_manager.mm
index 942a550e6e68cedd347e3731870ee3ae2b51a603..69d8d6826b2baf612df3ea9ba2f3cf871126a608 100644
--- a/ios/chrome/browser/passwords/credential_manager.mm
+++ b/ios/chrome/browser/passwords/credential_manager.mm
@@ -11,6 +11,8 @@
#include "base/memory/scoped_vector.h"
#include "base/strings/sys_string_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "components/password_manager/core/browser/form_fetcher.h"
+#include "components/password_manager/core/browser/form_saver.h"
vasilii 2016/12/21 11:00:49 unused?
vabr (Chromium) 2016/12/21 11:35:25 One of them. Done.
#include "components/password_manager/core/browser/password_store_consumer.h"
#include "components/password_manager/core/common/credential_manager_types.h"
#include "components/password_manager/core/common/password_manager_pref_names.h"
@@ -206,7 +208,7 @@ void CredentialManager::SignedIn(int request_id,
new password_manager::CredentialManagerPasswordFormManager(
client_, driver_->AsWeakPtr(),
*password_manager::CreateObservedPasswordFormFromOrigin(page_url),
- std::move(form), this));
+ std::move(form), this, nullptr, nullptr));
}
void CredentialManager::SignedOut(int request_id, const GURL& source_url) {

Powered by Google App Engine
This is Rietveld 408576698