Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.h

Issue 2592653003: Avoid use-after-free in FormFetcherImpl (Closed)
Patch Set: Typos Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_password_form_manager.h
diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.h b/components/password_manager/core/browser/credential_manager_password_form_manager.h
index c7a9efc13d846422a29f66db8855c680c6eb298f..6ac5a183a77086ae5e32fe392aa2a7b3e51a6aa1 100644
--- a/components/password_manager/core/browser/credential_manager_password_form_manager.h
+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.h
@@ -33,7 +33,9 @@ class CredentialManagerPasswordFormManager : public PasswordFormManager {
// Given a |client| and an |observed_form|, kick off the process of fetching
// matching logins from the password store; if |observed_form| doesn't map to
// a blacklisted origin, provisionally save |saved_form|. Once saved, let the
- // delegate know that it's safe to poke at the UI.
+ // delegate know that it's safe to poke at the UI. |form_fetcher| is passed
+ // to PasswordFormManager. |form_saver| can be null, in which case it is
+ // created automatically.
//
// This class does not take ownership of |delegate|.
CredentialManagerPasswordFormManager(
@@ -41,7 +43,9 @@ class CredentialManagerPasswordFormManager : public PasswordFormManager {
base::WeakPtr<PasswordManagerDriver> driver,
const autofill::PasswordForm& observed_form,
std::unique_ptr<autofill::PasswordForm> saved_form,
- CredentialManagerPasswordFormManagerDelegate* delegate);
+ CredentialManagerPasswordFormManagerDelegate* delegate,
+ std::unique_ptr<FormSaver> form_saver,
+ FormFetcher* form_fetcher);
~CredentialManagerPasswordFormManager() override;
void ProcessMatches(
@@ -49,9 +53,14 @@ class CredentialManagerPasswordFormManager : public PasswordFormManager {
size_t filtered_count) override;
private:
+ // Calls OnProvisionalSaveComplete on |delegate_|.
+ void NotifyDelegate();
+
CredentialManagerPasswordFormManagerDelegate* delegate_;
std::unique_ptr<autofill::PasswordForm> saved_form_;
+ base::WeakPtrFactory<CredentialManagerPasswordFormManager> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(CredentialManagerPasswordFormManager);
};

Powered by Google App Engine
This is Rietveld 408576698