Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: Source/web/WebViewImpl.cpp

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: changes done according to review comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebViewImpl.cpp
diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp
index c7bd60281f12277fc42607777511075a526ae111..25f99d23c7f2d6abe72e87bc58a626c55aaf87c2 100644
--- a/Source/web/WebViewImpl.cpp
+++ b/Source/web/WebViewImpl.cpp
@@ -3448,12 +3448,14 @@ void WebViewImpl::showContextMenu()
m_contextMenuAllowed = false;
}
-WebString WebViewImpl::getSmartClipData(WebRect rect)
+void WebViewImpl::getSmartClipData(WebRect rect, WebString* clipText, WebRect* clipRect)
{
LocalFrame* frame = toLocalFrame(focusedWebCoreFrame());
if (!frame)
- return WebString();
- return WebCore::SmartClip(frame).dataForRect(rect).toString();
+ return;
+ SmartClipData clipData = WebCore::SmartClip(frame).dataForRect(rect);
+ *clipText = clipData.getClipData();
+ *clipRect = clipData.getRect();
}
void WebViewImpl::hidePopups()
« no previous file with comments | « Source/web/WebViewImpl.h ('k') | public/web/WebView.h » ('j') | public/web/WebView.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698