Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: public/web/WebView.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: changed according to review comments by eseidel Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/tests/WebViewTest.cpp ('K') | « Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebView.h
diff --git a/public/web/WebView.h b/public/web/WebView.h
index 098baacc4a548db3256e29a91914fe5c78cecd74..8f0504a98b427f0e629d847f3a4b276cf8dfa7d7 100644
--- a/public/web/WebView.h
+++ b/public/web/WebView.h
@@ -409,8 +409,12 @@ public:
// SmartClip support ---------------------------------------------------
+ // TODO(AviD):This should be removed when the chromium side patch lands
Inactive 2014/06/09 14:47:10 Same comment about FIXME without attribution.
AviD 2014/06/13 11:52:48 Done.
+ // http://codereview.chromium.org/260623004
virtual WebString getSmartClipData(WebRect) = 0;
+ virtual void getSmartClipData(WebRect, WebString*, WebRect*) = 0;
+
// Popup menu ----------------------------------------------------------
« Source/web/tests/WebViewTest.cpp ('K') | « Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698