public/web/WebView.h - Issue 259263003: Fix to remove customised String over IPC for SmartClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebView.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added TODO in WebView.h (Avoid build dependency) Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebView.h

diff --git a/public/web/WebView.h b/public/web/WebView.h

index 098baacc4a548db3256e29a91914fe5c78cecd74..8f0504a98b427f0e629d847f3a4b276cf8dfa7d7 100644

--- a/public/web/WebView.h

+++ b/public/web/WebView.h

@@ -409,8 +409,12 @@ public:

// SmartClip support ---------------------------------------------------

+ // TODO(AviD):This should be removed when the chromium side patch lands

+ // http://codereview.chromium.org/260623004

virtual WebString getSmartClipData(WebRect) = 0;

+ virtual void getSmartClipData(WebRect, WebString*, WebRect*) = 0;

// Popup menu ----------------------------------------------------------

« Source/core/frame/SmartClip.h ('K') | « Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »