Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/web/WebViewImpl.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added TODO in WebView.h (Avoid build dependency) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/SmartClip.h ('K') | « Source/core/frame/SmartClip.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebViewImpl.h
diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h
index 6cfa048a782361068c85b95edc2b7099ede399c2..0d503637db38788a705ccb2541ac61accfe61938 100644
--- a/Source/web/WebViewImpl.h
+++ b/Source/web/WebViewImpl.h
@@ -246,7 +246,10 @@ public:
unsigned inactiveForegroundColor) OVERRIDE;
virtual void performCustomContextMenuAction(unsigned action) OVERRIDE;
virtual void showContextMenu() OVERRIDE;
+ // TODO(AviD):This should be removed when the chromium side patch lands
+ // http://codereview.chromium.org/260623004
virtual WebString getSmartClipData(WebRect) OVERRIDE;
+ virtual void getSmartClipData(WebRect, WebString*, WebRect*) OVERRIDE;
virtual void hidePopups() OVERRIDE;
virtual void addPageOverlay(WebPageOverlay*, int /* zOrder */) OVERRIDE;
virtual void removePageOverlay(WebPageOverlay*) OVERRIDE;
« Source/core/frame/SmartClip.h ('K') | « Source/core/frame/SmartClip.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698