Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: Source/core/frame/SmartClip.h

Issue 259263003: Fix to remove customised String over IPC for SmartClip (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added TODO in WebView.h (Avoid build dependency) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 { 42 {
43 } 43 }
44 44
45 SmartClipData(Node* node, IntRect rect, String string) 45 SmartClipData(Node* node, IntRect rect, String string)
46 : m_node(node) 46 : m_node(node)
47 , m_rect(rect) 47 , m_rect(rect)
48 , m_string(string) 48 , m_string(string)
49 { 49 {
50 } 50 }
51 51
52 String toString(); 52 IntRect getRect() const;
eseidel 2014/06/02 16:37:50 We don't use "get" for getters. Does this rect ha
AviD 2014/06/03 05:54:00 Done.
53 String getClipData() const;
eseidel 2014/06/02 16:37:50 How is this different from the toString above?
AviD 2014/06/03 05:54:00 the toString() had customized string with both rec
53 54
54 private: 55 private:
55 RefPtr<Node> m_node; 56 RefPtr<Node> m_node;
56 IntRect m_rect; 57 IntRect m_rect;
57 String m_string; 58 String m_string;
58 }; 59 };
59 60
60 // SmartClip implements support for the copy operation 61 // SmartClip implements support for the copy operation
61 // with an S-Pen on Samsung devices. The behavior of this 62 // with an S-Pen on Samsung devices. The behavior of this
62 // class is quirky and poorly tested. It's approximately 63 // class is quirky and poorly tested. It's approximately
(...skipping 14 matching lines...) Expand all
77 void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, Vector<Node*>& overlappingNodeInfoTable); 78 void collectOverlappingChildNodes(Node* parentNode, const IntRect& cropRect, Vector<Node*>& overlappingNodeInfoTable);
78 IntRect convertRectToWindow(const IntRect& nodeRect); 79 IntRect convertRectToWindow(const IntRect& nodeRect);
79 String extractTextFromNode(Node*); 80 String extractTextFromNode(Node*);
80 81
81 RefPtr<LocalFrame> m_frame; 82 RefPtr<LocalFrame> m_frame;
82 }; 83 };
83 84
84 } // namespace WebCore 85 } // namespace WebCore
85 86
86 #endif // SmartClip_h 87 #endif // SmartClip_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/SmartClip.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698