Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: services/service_manager/service_manager.cc

Issue 2592623002: mojo:: Introduce InterfaceRequest ctor that takes in InterfacePtr* (Closed)
Patch Set: Rebase + response to review Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/service_manager/public/cpp/lib/connector_impl.cc ('k') | services/ui/gpu/gpu_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/service_manager/service_manager.cc
diff --git a/services/service_manager/service_manager.cc b/services/service_manager/service_manager.cc
index 2ca6a3a02ba15201c8a3664cd9a291574aae87bd..091ce5838a5f72d34e4a51a9b0682313ba32b5ea 100644
--- a/services/service_manager/service_manager.cc
+++ b/services/service_manager/service_manager.cc
@@ -514,7 +514,7 @@ ServiceManager::ServiceManager(
std::move(service_process_launcher_factory)),
weak_ptr_factory_(this) {
mojom::ServicePtr service;
- mojom::ServiceRequest request = mojo::MakeRequest(&service);
+ mojom::ServiceRequest request(&service);
InterfaceProviderSpec spec;
spec.provides[kCapability_ServiceManager].insert(
@@ -581,7 +581,7 @@ mojom::ServiceRequest ServiceManager::StartEmbedderService(
params->set_target(embedder_identity);
mojom::ServicePtr service;
- mojom::ServiceRequest request = mojo::MakeRequest(&service);
+ mojom::ServiceRequest request(&service);
Connect(std::move(params), std::move(service), nullptr);
return request;
@@ -879,7 +879,7 @@ void ServiceManager::OnGotResolvedName(std::unique_ptr<ConnectParams> params,
std::move(client_process_connection));
} else {
// Otherwise we create a new Service pipe.
- mojom::ServiceRequest request = MakeRequest(&service);
+ mojom::ServiceRequest request(&service);
CHECK(!result->package_path.empty());
// The catalog was unable to read a manifest for this service. We can't do
« no previous file with comments | « services/service_manager/public/cpp/lib/connector_impl.cc ('k') | services/ui/gpu/gpu_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698