content/browser/tracing/memory_tracing_browsertest.cc - Issue 2592543002: Make memory-infra tests register / unregister with thread safety

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/memory_tracing_browsertest.cc

Issue 2592543002: Make memory-infra tests register / unregister with thread safety (Closed)

Patch Set: fix tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/memory_tracing_browsertest.cc

diff --git a/content/browser/tracing/memory_tracing_browsertest.cc b/content/browser/tracing/memory_tracing_browsertest.cc

index c015532545d76bb436d9cd4ae7197d66926fb9cc..fe966660829131db6aa2442692f1e5c05a707fd4 100644

--- a/content/browser/tracing/memory_tracing_browsertest.cc

+++ b/content/browser/tracing/memory_tracing_browsertest.cc

@@ -103,8 +103,8 @@ class MemoryTracingTest : public ContentBrowserTest {

}

void TearDown() override {

- MemoryDumpManager::GetInstance()->UnregisterDumpProvider(

- mock_dump_provider_.get());

+ MemoryDumpManager::GetInstance()->UnregisterAndDeleteDumpProviderSoon(

+ std::move(mock_dump_provider_));

mock_dump_provider_.reset();

ContentBrowserTest::TearDown();

}