Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Side by Side Diff: ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc

Issue 259253002: Add OnDisplayMetricsChanged in DisplayObserver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_orientation
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_screen_x11.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/widget/desktop_aura/desktop_screen_x11.h" 5 #include "ui/views/widget/desktop_aura/desktop_screen_x11.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 new views::DesktopNativeWidgetAura(toplevel); 169 new views::DesktopNativeWidgetAura(toplevel);
170 } 170 }
171 toplevel_params.bounds = bounds; 171 toplevel_params.bounds = bounds;
172 toplevel_params.remove_standard_frame = true; 172 toplevel_params.remove_standard_frame = true;
173 toplevel->Init(toplevel_params); 173 toplevel->Init(toplevel_params);
174 return toplevel; 174 return toplevel;
175 } 175 }
176 176
177 private: 177 private:
178 // Overridden from gfx::DisplayObserver: 178 // Overridden from gfx::DisplayObserver:
179 virtual void OnDisplayBoundsChanged(const gfx::Display& display) OVERRIDE {
180 changed_display_.push_back(display);
181 }
182
183 virtual void OnDisplayAdded(const gfx::Display& new_display) OVERRIDE { 179 virtual void OnDisplayAdded(const gfx::Display& new_display) OVERRIDE {
184 added_display_.push_back(new_display); 180 added_display_.push_back(new_display);
185 } 181 }
186 182
187 virtual void OnDisplayRemoved(const gfx::Display& old_display) OVERRIDE { 183 virtual void OnDisplayRemoved(const gfx::Display& old_display) OVERRIDE {
188 removed_display_.push_back(old_display); 184 removed_display_.push_back(old_display);
189 } 185 }
190 186
187 virtual void OnDisplayMetricsChanged(const gfx::Display& display,
188 uint32_t metrics) OVERRIDE {
189 changed_display_.push_back(display);
190 }
191
191 scoped_ptr<DesktopScreenX11> screen_; 192 scoped_ptr<DesktopScreenX11> screen_;
192 193
193 DISALLOW_COPY_AND_ASSIGN(DesktopScreenX11Test); 194 DISALLOW_COPY_AND_ASSIGN(DesktopScreenX11Test);
194 }; 195 };
195 196
196 TEST_F(DesktopScreenX11Test, BoundsChangeSingleMonitor) { 197 TEST_F(DesktopScreenX11Test, BoundsChangeSingleMonitor) {
197 std::vector<gfx::Display> displays; 198 std::vector<gfx::Display> displays;
198 displays.push_back(gfx::Display(kFirstDisplay, gfx::Rect(0, 0, 1024, 768))); 199 displays.push_back(gfx::Display(kFirstDisplay, gfx::Rect(0, 0, 1024, 768)));
199 screen()->ProcessDisplayChange(displays); 200 screen()->ProcessDisplayChange(displays);
200 201
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
448 generator.PressRightButton(); 449 generator.PressRightButton();
449 generator.ReleaseRightButton(); 450 generator.ReleaseRightButton();
450 EXPECT_FALSE(rwh->IsMaximized()); 451 EXPECT_FALSE(rwh->IsMaximized());
451 generator.DoubleClickLeftButton(); 452 generator.DoubleClickLeftButton();
452 RunPendingMessages(); 453 RunPendingMessages();
453 EXPECT_FALSE(rwh->IsMaximized()); 454 EXPECT_FALSE(rwh->IsMaximized());
454 455
455 widget->CloseNow(); 456 widget->CloseNow();
456 } 457 }
457 458
459 // Test that rotating the displays notifies the DisplayObservers.
460 TEST_F(DesktopScreenX11Test, RotationChange) {
461 std::vector<gfx::Display> displays;
462 displays.push_back(gfx::Display(kFirstDisplay, gfx::Rect(0, 0, 640, 480)));
463 displays.push_back(
464 gfx::Display(kSecondDisplay, gfx::Rect(640, 0, 1024, 768)));
465 screen()->ProcessDisplayChange(displays);
466 ResetDisplayChanges();
467
468 displays[0].set_rotation(gfx::Display::ROTATE_90);
469 screen()->ProcessDisplayChange(displays);
470 EXPECT_EQ(1u, changed_display_.size());
471
472 displays[1].set_rotation(gfx::Display::ROTATE_90);
473 screen()->ProcessDisplayChange(displays);
474 EXPECT_EQ(2u, changed_display_.size());
475
476 displays[0].set_rotation(gfx::Display::ROTATE_270);
477 screen()->ProcessDisplayChange(displays);
478 EXPECT_EQ(3u, changed_display_.size());
479
480 displays[0].set_rotation(gfx::Display::ROTATE_270);
481 screen()->ProcessDisplayChange(displays);
482 EXPECT_EQ(3u, changed_display_.size());
483
484 displays[0].set_rotation(gfx::Display::ROTATE_0);
485 displays[1].set_rotation(gfx::Display::ROTATE_0);
486 screen()->ProcessDisplayChange(displays);
487 EXPECT_EQ(5u, changed_display_.size());
488 }
489
490 // Test that changing the displays workarea notifies the DisplayObservers.
491 TEST_F(DesktopScreenX11Test, WorkareaChange) {
492 std::vector<gfx::Display> displays;
493 displays.push_back(gfx::Display(kFirstDisplay, gfx::Rect(0, 0, 640, 480)));
494 displays.push_back(
495 gfx::Display(kSecondDisplay, gfx::Rect(640, 0, 1024, 768)));
496 screen()->ProcessDisplayChange(displays);
497 ResetDisplayChanges();
498
499 displays[0].set_work_area(gfx::Rect(0, 0, 300, 300));
500 screen()->ProcessDisplayChange(displays);
501 EXPECT_EQ(1u, changed_display_.size());
502
503 displays[1].set_work_area(gfx::Rect(0, 0, 300, 300));
504 screen()->ProcessDisplayChange(displays);
505 EXPECT_EQ(2u, changed_display_.size());
506
507 displays[0].set_work_area(gfx::Rect(0, 0, 300, 300));
508 screen()->ProcessDisplayChange(displays);
509 EXPECT_EQ(2u, changed_display_.size());
510
511 displays[1].set_work_area(gfx::Rect(0, 0, 300, 300));
512 screen()->ProcessDisplayChange(displays);
513 EXPECT_EQ(2u, changed_display_.size());
514
515 displays[0].set_work_area(gfx::Rect(0, 0, 640, 480));
516 displays[1].set_work_area(gfx::Rect(640, 0, 1024, 768));
517 screen()->ProcessDisplayChange(displays);
518 EXPECT_EQ(4u, changed_display_.size());
519 }
520
521 // Test that changing the device scale factor notifies the DisplayObservers.
522 TEST_F(DesktopScreenX11Test, DeviceScaleFactorChange) {
523 std::vector<gfx::Display> displays;
524 displays.push_back(gfx::Display(kFirstDisplay, gfx::Rect(0, 0, 640, 480)));
525 displays.push_back(
526 gfx::Display(kSecondDisplay, gfx::Rect(640, 0, 1024, 768)));
527 screen()->ProcessDisplayChange(displays);
528 ResetDisplayChanges();
529
530 displays[0].set_device_scale_factor(2.5f);
531 screen()->ProcessDisplayChange(displays);
532 EXPECT_EQ(1u, changed_display_.size());
533
534 displays[1].set_device_scale_factor(2.5f);
535 screen()->ProcessDisplayChange(displays);
536 EXPECT_EQ(2u, changed_display_.size());
537
538 displays[0].set_device_scale_factor(2.5f);
539 screen()->ProcessDisplayChange(displays);
540 EXPECT_EQ(2u, changed_display_.size());
541
542 displays[1].set_device_scale_factor(2.5f);
543 screen()->ProcessDisplayChange(displays);
544 EXPECT_EQ(2u, changed_display_.size());
545
546 displays[0].set_device_scale_factor(1.f);
547 displays[1].set_device_scale_factor(1.f);
548 screen()->ProcessDisplayChange(displays);
549 EXPECT_EQ(4u, changed_display_.size());
550 }
551
458 } // namespace views 552 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/widget/desktop_aura/desktop_screen_x11.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698