Add OnDisplayMetricsChanged in DisplayObserver.

chrome/browser/extensions/api/system_info/system_info_api.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/system_info/system_info_api.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 48 matching lines @@
 
   SystemInfoEventRouter();
   virtual ~SystemInfoEventRouter();
 
   // Add/remove event listener for the |event_name| event.
   void AddEventListener(const std::string& event_name);
   void RemoveEventListener(const std::string& event_name);
 
  private:
   // gfx::DisplayObserver:
-  virtual void OnDisplayBoundsChanged(const gfx::Display& display) OVERRIDE;
   virtual void OnDisplayAdded(const gfx::Display& new_display) OVERRIDE;
   virtual void OnDisplayRemoved(const gfx::Display& old_display) OVERRIDE;
+  virtual void OnDisplayMetricsChanged(const gfx::Display& display,
+      DisplayObserver::DisplayMetrics metrics) OVERRIDE;

[jochen (gone - plz use gerrit), 2014/05/14 09:05:43]

please clang-format

 
   // RemovableStorageObserver implementation.
   virtual void OnRemovableStorageAttached(
       const storage_monitor::StorageInfo& info) OVERRIDE;
   virtual void OnRemovableStorageDetached(
       const storage_monitor::StorageInfo& info) OVERRIDE;
 
   // Called from any thread to dispatch the systemInfo event to all extension
   // processes cross multiple profiles.
   void DispatchEvent(const std::string& event_name,
@@ skipping 93 matching lines @@
     const storage_monitor::StorageInfo& info) {
   scoped_ptr<base::ListValue> args(new base::ListValue);
   std::string transient_id =
       StorageMonitor::GetInstance()->GetTransientIdForDeviceId(
           info.device_id());
   args->AppendString(transient_id);
 
   DispatchEvent(system_storage::OnDetached::kEventName, args.Pass());
 }
 
-void SystemInfoEventRouter::OnDisplayBoundsChanged(
-    const gfx::Display& display) {
-  OnDisplayChanged();
-}
-
 void SystemInfoEventRouter::OnDisplayAdded(const gfx::Display& new_display) {
   OnDisplayChanged();
 }
 
 void SystemInfoEventRouter::OnDisplayRemoved(const gfx::Display& old_display) {
   OnDisplayChanged();
 }
 
+void SystemInfoEventRouter::OnDisplayMetricsChanged(
+    const gfx::Display&, DisplayObserver::DisplayMetrics) {

[jochen (gone - plz use gerrit), 2014/05/14 09:05:43]

please do not omit parameter names

+  OnDisplayChanged();
+}
+
 void SystemInfoEventRouter::OnDisplayChanged() {
   scoped_ptr<base::ListValue> args(new base::ListValue());
   DispatchEvent(system_display::OnDisplayChanged::kEventName, args.Pass());
 }
 
 void SystemInfoEventRouter::DispatchEvent(const std::string& event_name,
                                           scoped_ptr<base::ListValue> args) {
   g_browser_process->extension_event_router_forwarder()->
       BroadcastEventToRenderers(event_name, args.Pass(), GURL());
 }
@@ skipping 44 matching lines @@
 void SystemInfoAPI::OnListenerRemoved(const EventListenerInfo& details) {
   if (IsSystemStorageEvent(details.event_name)) {
     StorageMonitor::GetInstance()->EnsureInitialized(
         base::Bind(&RemoveEventListener, details.event_name));
   } else {
     RemoveEventListener(details.event_name);
   }
 }
 
 }  // namespace extensions