Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html

Issue 2592513002: DevTools: Add Closure docs and clean up UISourceCode (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
index d936f5e31876295846b936dec8e551118aa0da29..6be2c6181032b3aece75d91da0221030677f40d4 100644
--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
@@ -104,8 +104,8 @@ function test()
{
uiSourceCode1.addRevision("<snippet content>");
InspectorTest.addResult("Snippet content set.");
- delete uiSourceCode1._content;
- delete uiSourceCode1._contentLoaded;
+ uiSourceCode1._requestContentPromise = null;
einbinder 2016/12/19 21:34:16 There was a race condition before with _requestCon
+ uiSourceCode1.contentLoaded = false;
uiSourceCode1.requestContent()
.then(contentCallback)
.then(contentDumped2)
@@ -128,8 +128,8 @@ function test()
renameSnippetAndCheckWorkspace(uiSourceCode1, "foo");
renameSnippetAndCheckWorkspace(uiSourceCode2, "bar");
renameSnippetAndCheckWorkspace(uiSourceCode2, "foo");
- delete uiSourceCode1._content;
- delete uiSourceCode1._contentLoaded;
+ uiSourceCode1._requestContentPromise = null;
+ uiSourceCode1.contentLoaded = false;
uiSourceCode1.requestContent()
.then(contentCallback)
.then(onContentDumped);

Powered by Google App Engine
This is Rietveld 408576698