Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2592443002: Media Controls: use events to enter/exit fullscreen. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 3d20d30d1a36e669d41369605c916589e5e1c4fd..2fb8a5766fc10109781f0b259208a86cbbe42b39 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -3432,8 +3432,6 @@ bool HTMLMediaElement::isFullscreen() const {
void HTMLMediaElement::didEnterFullscreen() {
configureMediaControls();
- if (mediaControls())
- mediaControls()->enteredFullscreen();
// FIXME: There is no embedder-side handling in layout test mode.
if (webMediaPlayer() && !LayoutTestSupport::isRunningLayoutTest())
webMediaPlayer()->enteredFullscreen();
@@ -3446,8 +3444,6 @@ void HTMLMediaElement::didEnterFullscreen() {
void HTMLMediaElement::didExitFullscreen() {
configureMediaControls();
- if (mediaControls())
- mediaControls()->exitedFullscreen();
if (webMediaPlayer())
webMediaPlayer()->exitedFullscreen();
if (m_inOverlayFullscreenVideo)
@@ -3622,10 +3618,7 @@ void HTMLMediaElement::ensureMediaControls() {
return;
MediaControls* mediaControls = MediaControls::create(*this);
-
mediaControls->reset();
- if (isFullscreen())
- mediaControls->enteredFullscreen();
ShadowRoot& shadowRoot = ensureUserAgentShadowRoot();
assertShadowRootChildren(shadowRoot);

Powered by Google App Engine
This is Rietveld 408576698