third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js - Issue 2592433003: [DevTools] Replace ViewportControl with ListControl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

Issue 2592433003: [DevTools] Replace ViewportControl with ListControl. (Closed)

Patch Set: tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/module.json ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/FilteredListWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

index e70cb71d40eb3a2eaccb92be3aff155fce215dfc..93d494dcf4de2a48f15d899b558fdb3b0ad0ef03 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/CommandMenu.js

@@ -225,10 +225,12 @@ UI.CommandMenuDelegate = class extends UI.FilteredListWidget.Delegate {

/**

* @override

- * @param {number} itemIndex

+ * @param {?number} itemIndex

* @param {string} promptValue

selectItem(itemIndex, promptValue) {

+ if (itemIndex === null)

+ return;

this._commands[itemIndex].execute();

}