Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js

Issue 2592433003: [DevTools] Replace ViewportControl with ListControl. (Closed)
Patch Set: tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
diff --git a/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js b/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
index a69ae525d729b51ab44ad63ccc690c1fada5f4ca..bf1dff27f8a951c8cfe4578038b96bbf6b6cf731 100644
--- a/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
+++ b/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
@@ -118,10 +118,10 @@ TestRunner.loadLazyModules = function(lazyModules) {
/**
* @param {string} key
- * @param {boolean} ctrlKey
- * @param {boolean} altKey
- * @param {boolean} shiftKey
- * @param {boolean} metaKey
+ * @param {boolean=} ctrlKey
+ * @param {boolean=} altKey
+ * @param {boolean=} shiftKey
+ * @param {boolean=} metaKey
* @return {!KeyboardEvent}
*/
TestRunner.createKeyEvent = function(key, ctrlKey, altKey, shiftKey, metaKey) {
@@ -129,10 +129,10 @@ TestRunner.createKeyEvent = function(key, ctrlKey, altKey, shiftKey, metaKey) {
key: key,
bubbles: true,
cancelable: true,
- ctrlKey: ctrlKey,
- altKey: altKey,
- shiftKey: shiftKey,
- metaKey: metaKey
+ ctrlKey: !!ctrlKey,
+ altKey: !!altKey,
+ shiftKey: !!shiftKey,
+ metaKey: !!metaKey
});
};

Powered by Google App Engine
This is Rietveld 408576698