Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h

Issue 2592363002: FontResourceTest: call unregisterURL() respectively (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
diff --git a/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h b/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
index c4bd3ec49dd4a1a7ad7af2f0e37df2ec1285f0a4..28b7808d6a354003f6b1d2ba8fe84fc0f29290ea 100644
--- a/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
+++ b/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
@@ -39,9 +39,14 @@ class WebURLLoaderMockFactoryImpl : public WebURLLoaderMockFactory {
// WebURLLoaderMockFactory:
virtual WebURLLoader* createURLLoader(WebURLLoader* default_loader) override;
+ // Register an arbitorary |response| for a specified |url|. unregisterURL()
+ // should be called for each test before registering another |response| for
+ // the same |url| for another test.
void registerURL(const WebURL& url,
const WebURLResponse& response,
const WebString& filePath = WebString()) override;
+ // unregisterURL() should be called for each test before registering another
+ // |response| for the same |url| for another test.
kinuko 2016/12/22 06:39:26 These are WebURLLoaderMockFactory overrides, we ma
Takashi Toyoshima 2016/12/22 07:02:59 Done.
void registerErrorURL(const WebURL& url,
const WebURLResponse& response,
const WebURLError& error) override;

Powered by Google App Engine
This is Rietveld 408576698