Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 259233002: Add a basic gn file for V8 (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a basic gn file for V8 Currently, the gn support is incomplete and only works from within a chromium checkout. See https://code.google.com/p/chromium/wiki/gn for details We move the BUILD.gn file to v8 nevertheless to make renaming files easier, as the chromium CQ already now checks the gn build. BUG=none R=brettw@chromium.org, machenbach@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=21140

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+793 lines, -0 lines) Patch
A BUILD.gn View 1 chunk +793 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
PTAL Will it be possible to have a root group in that file as well ...
6 years, 7 months ago (2014-04-29 15:05:02 UTC) #1
brettw
LGTM! https://codereview.chromium.org/259233002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/259233002/diff/1/BUILD.gn#newcode35 BUILD.gn:35: # TODO(jochen): Do actions need visibility settings as ...
6 years, 7 months ago (2014-04-29 17:09:46 UTC) #2
Michael Achenbach
Rubberstamp lgtm.
6 years, 7 months ago (2014-05-05 10:25:07 UTC) #3
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-05 11:06:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698