Reland [Mojo Video Capture] Replace method OnIncomingCapturedVideoFrame() with OnIncomingCapturedBuf

content/browser/renderer_host/media/video_capture_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit test for VideoCaptureController.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <stdint.h>
 #include <string.h>
@@ skipping 142 matching lines @@
     controller_->SetConsumerFeedbackObserver(
         std::move(consumer_feedback_observer));
     client_a_.reset(new MockVideoCaptureControllerEventHandler(
         controller_.get()));
     client_b_.reset(new MockVideoCaptureControllerEventHandler(
         controller_.get()));
   }
 
   void TearDown() override { base::RunLoop().RunUntilIdle(); }
 
-  scoped_refptr<media::VideoFrame> WrapBuffer(
-      gfx::Size dimensions,
-      uint8_t* data,
-      media::VideoPixelFormat format = media::PIXEL_FORMAT_I420) {
-    scoped_refptr<media::VideoFrame> video_frame =
-        media::VideoFrame::WrapExternalSharedMemory(
-            format, dimensions, gfx::Rect(dimensions), dimensions, data,
-            media::VideoFrame::AllocationSize(format, dimensions),
-            base::SharedMemory::NULLHandle(), 0u, base::TimeDelta());
-    EXPECT_TRUE(video_frame);
-    return video_frame;
-  }
-
   TestBrowserThreadBundle bundle_;
   std::unique_ptr<MockVideoCaptureControllerEventHandler> client_a_;
   std::unique_ptr<MockVideoCaptureControllerEventHandler> client_b_;
   std::unique_ptr<VideoCaptureController> controller_;
   std::unique_ptr<media::VideoCaptureDevice::Client> device_client_;
   MockFrameBufferPool* mock_frame_receiver_observer_;
   MockConsumerFeedbackObserver* mock_consumer_feedback_observer_;
+  const float arbitrary_frame_rate_ = 10.0f;
+  const base::TimeTicks arbitrary_reference_time_ = base::TimeTicks();
+  const base::TimeDelta arbitrary_timestamp_ = base::TimeDelta();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(VideoCaptureControllerTest);
 };
 
 // A simple test of VideoCaptureController's ability to add, remove, and keep
 // track of clients.
 TEST_F(VideoCaptureControllerTest, AddAndRemoveClients) {
   media::VideoCaptureParams session_100;
   session_100.requested_format = media::VideoCaptureFormat(
@@ skipping 99 matching lines @@
 
   session_100.requested_format =
       media::VideoCaptureFormat(gfx::Size(320, 240), 30, format);
 
   media::VideoCaptureParams session_200 = session_100;
 
   media::VideoCaptureParams session_300 = session_100;
 
   media::VideoCaptureParams session_1 = session_100;
 
-  const gfx::Size capture_resolution(444, 200);
-
-  // The device format needn't match the VideoCaptureParams (the camera can do
-  // what it wants). Pick something random.
-  media::VideoCaptureFormat device_format(
-      gfx::Size(10, 10), 25, media::PIXEL_FORMAT_RGB24);
+  media::VideoCaptureFormat device_format(gfx::Size(444, 200), 25, format);
 
   const VideoCaptureControllerID client_a_route_1(0xa1a1a1a1);
   const VideoCaptureControllerID client_a_route_2(0xa2a2a2a2);
   const VideoCaptureControllerID client_b_route_1(0xb1b1b1b1);
   const VideoCaptureControllerID client_b_route_2(0xb2b2b2b2);
 
-  // Start with two clients.
   controller_->AddClient(client_a_route_1,
                          client_a_.get(),
                          100,
                          session_100);
   controller_->AddClient(client_b_route_1,
                          client_b_.get(),
                          300,
                          session_300);
   controller_->AddClient(client_a_route_2,
                          client_a_.get(),
                          200,
                          session_200);
   ASSERT_EQ(3, controller_->GetClientCount());
 
   // Now, simulate an incoming captured buffer from the capture device. As a
   // side effect this will cause the first buffer to be shared with clients.
   uint8_t buffer_no = 1;
   const int arbitrary_frame_feedback_id = 101;
   ASSERT_EQ(0.0, device_client_->GetBufferPoolUtilization());
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer(
-      device_client_->ReserveOutputBuffer(capture_resolution, format,
-                                          media::PIXEL_STORAGE_CPU,
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
                                           arbitrary_frame_feedback_id));
   ASSERT_TRUE(buffer.get());
   ASSERT_EQ(1.0 / kPoolSize, device_client_->GetBufferPoolUtilization());
   memset(buffer->data(), buffer_no++, buffer->mapped_size());
   {
     InSequence s;
     EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_1)).Times(1);
-    EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_1, capture_resolution))
+    EXPECT_CALL(*client_a_,
+                DoBufferReady(client_a_route_1, device_format.frame_size))
         .Times(1);
   }
   {
     InSequence s;
     EXPECT_CALL(*client_b_, DoBufferCreated(client_b_route_1)).Times(1);
-    EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_1, capture_resolution))
+    EXPECT_CALL(*client_b_,
+                DoBufferReady(client_b_route_1, device_format.frame_size))
         .Times(1);
   }
   {
     InSequence s;
     EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_2)).Times(1);
-    EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_2, capture_resolution))
+    EXPECT_CALL(*client_a_,
+                DoBufferReady(client_a_route_2, device_format.frame_size))
         .Times(1);
   }
-  scoped_refptr<media::VideoFrame> video_frame = WrapBuffer(
-      capture_resolution, static_cast<uint8_t*>(buffer->data()), format);
-  ASSERT_TRUE(video_frame);
-  ASSERT_FALSE(video_frame->metadata()->HasKey(
-      media::VideoFrameMetadata::RESOURCE_UTILIZATION));
   client_a_->resource_utilization_ = 0.5;
   client_b_->resource_utilization_ = -1.0;
   {
     InSequence s;
     EXPECT_CALL(*mock_frame_receiver_observer_, SetBufferHold(buffer->id()))
         .Times(1);
     // Expect VideoCaptureController to call the load observer with a
     // resource utilization of 0.5 (the largest of all reported values).
     EXPECT_CALL(*mock_consumer_feedback_observer_,
                 OnUtilizationReport(arbitrary_frame_feedback_id, 0.5))
         .Times(1);
     EXPECT_CALL(*mock_frame_receiver_observer_, ReleaseBufferHold(buffer->id()))
         .Times(1);
   }
 
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer), video_frame);
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
 
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
   Mock::VerifyAndClearExpectations(client_b_.get());
   Mock::VerifyAndClearExpectations(mock_consumer_feedback_observer_);
   Mock::VerifyAndClearExpectations(mock_frame_receiver_observer_);
 
   // Second buffer which ought to use the same shared memory buffer. In this
   // case pretend that the Buffer pointer is held by the device for a long
   // delay. This shouldn't affect anything.
   const int arbitrary_frame_feedback_id_2 = 102;
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer2 =
-      device_client_->ReserveOutputBuffer(capture_resolution, format,
-                                          media::PIXEL_STORAGE_CPU,
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
                                           arbitrary_frame_feedback_id_2);
   ASSERT_TRUE(buffer2.get());
   memset(buffer2->data(), buffer_no++, buffer2->mapped_size());
-  video_frame = WrapBuffer(capture_resolution,
-                           static_cast<uint8_t*>(buffer2->data()), format);
   client_a_->resource_utilization_ = 0.5;
   client_b_->resource_utilization_ = 3.14;
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
   // Expect VideoCaptureController to call the load observer with a
   // resource utilization of 3.14 (the largest of all reported values).
   {
     InSequence s;
     EXPECT_CALL(*mock_frame_receiver_observer_, SetBufferHold(buffer2->id()))
         .Times(1);
     // Expect VideoCaptureController to call the load observer with a
     // resource utilization of 3.14 (the largest of all reported values).
     EXPECT_CALL(*mock_consumer_feedback_observer_,
                 OnUtilizationReport(arbitrary_frame_feedback_id_2, 3.14))
         .Times(1);
     EXPECT_CALL(*mock_frame_receiver_observer_,
                 ReleaseBufferHold(buffer2->id()))
         .Times(1);
   }
 
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer2), video_frame);
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer2),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
 
   // The buffer should be delivered to the clients in any order.
   {
     InSequence s;
     EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_1)).Times(1);
-    EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_1, capture_resolution))
+    EXPECT_CALL(*client_a_,
+                DoBufferReady(client_a_route_1, device_format.frame_size))
         .Times(1);
   }
   {
     InSequence s;
     EXPECT_CALL(*client_b_, DoBufferCreated(client_b_route_1)).Times(1);
-    EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_1, capture_resolution))
+    EXPECT_CALL(*client_b_,
+                DoBufferReady(client_b_route_1, device_format.frame_size))
         .Times(1);
   }
   {
     InSequence s;
     EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_2)).Times(1);
-    EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_2, capture_resolution))
+    EXPECT_CALL(*client_a_,
+                DoBufferReady(client_a_route_2, device_format.frame_size))
         .Times(1);
   }
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
   Mock::VerifyAndClearExpectations(client_b_.get());
   Mock::VerifyAndClearExpectations(mock_consumer_feedback_observer_);
   Mock::VerifyAndClearExpectations(mock_frame_receiver_observer_);
 
   // Add a fourth client now that some buffers have come through.
   controller_->AddClient(client_b_route_2,
                          client_b_.get(),
                          1,
                          session_1);
   Mock::VerifyAndClearExpectations(client_b_.get());
 
   // Third, fourth, and fifth buffers. Pretend they all arrive at the same time.
   for (int i = 0; i < kPoolSize; i++) {
     const int arbitrary_frame_feedback_id = 200 + i;
     std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer =
-        device_client_->ReserveOutputBuffer(capture_resolution, format,
-                                            media::PIXEL_STORAGE_CPU,
+        device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                            device_format.pixel_format,
+                                            device_format.pixel_storage,
                                             arbitrary_frame_feedback_id);
     ASSERT_TRUE(buffer.get());
     memset(buffer->data(), buffer_no++, buffer->mapped_size());
-    video_frame = WrapBuffer(capture_resolution,
-                             static_cast<uint8_t*>(buffer->data()), format);
-    ASSERT_TRUE(video_frame);
-    video_frame->metadata()->SetTimeTicks(
-        media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-    device_client_->OnIncomingCapturedVideoFrame(std::move(buffer),
-                                                 video_frame);
+    device_client_->OnIncomingCapturedBuffer(std::move(buffer),
+      device_format,
+      arbitrary_reference_time_,
+      arbitrary_timestamp_);
   }
   // ReserveOutputBuffer ought to fail now, because the pool is depleted.
   ASSERT_FALSE(device_client_
-                   ->ReserveOutputBuffer(capture_resolution, format,
-                                         media::PIXEL_STORAGE_CPU,
+                   ->ReserveOutputBuffer(device_format.frame_size,
+                                         device_format.pixel_format,
+                                         device_format.pixel_storage,
                                          arbitrary_frame_feedback_id)
                    .get());
 
   // The new client needs to be notified of the creation of |kPoolSize| buffers;
   // the old clients only |kPoolSize - 2|.
   EXPECT_CALL(*client_b_, DoBufferCreated(client_b_route_2)).Times(kPoolSize);
-  EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_2, capture_resolution))
+  EXPECT_CALL(*client_b_,
+              DoBufferReady(client_b_route_2, device_format.frame_size))
       .Times(kPoolSize);
   EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_1))
       .Times(kPoolSize - 2);
-  EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_1, capture_resolution))
+  EXPECT_CALL(*client_a_,
+              DoBufferReady(client_a_route_1, device_format.frame_size))
       .Times(kPoolSize);
   EXPECT_CALL(*client_a_, DoBufferCreated(client_a_route_2))
       .Times(kPoolSize - 2);
-  EXPECT_CALL(*client_a_, DoBufferReady(client_a_route_2, capture_resolution))
+  EXPECT_CALL(*client_a_,
+              DoBufferReady(client_a_route_2, device_format.frame_size))
       .Times(kPoolSize);
   EXPECT_CALL(*client_b_, DoBufferCreated(client_b_route_1))
       .Times(kPoolSize - 2);
-  EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_1, capture_resolution))
+  EXPECT_CALL(*client_b_,
+              DoBufferReady(client_b_route_1, device_format.frame_size))
       .Times(kPoolSize);
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
   Mock::VerifyAndClearExpectations(client_b_.get());
 
   // Now test the interaction of client shutdown and buffer delivery.
   // Kill A1 via renderer disconnect (synchronous).
   controller_->RemoveClient(client_a_route_1, client_a_.get());
   // Kill B1 via session close (posts a task to disconnect).
   EXPECT_CALL(*client_b_, DoEnded(client_b_route_1)).Times(1);
   controller_->StopSession(300);
   // Queue up another buffer.
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer3 =
-      device_client_->ReserveOutputBuffer(capture_resolution, format,
-                                          media::PIXEL_STORAGE_CPU,
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
                                           arbitrary_frame_feedback_id);
   ASSERT_TRUE(buffer3.get());
   memset(buffer3->data(), buffer_no++, buffer3->mapped_size());
-  video_frame = WrapBuffer(capture_resolution,
-                           static_cast<uint8_t*>(buffer3->data()), format);
-  ASSERT_TRUE(video_frame);
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer3), video_frame);
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer3),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
 
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer4 =
-      device_client_->ReserveOutputBuffer(capture_resolution, format,
-                                          media::PIXEL_STORAGE_CPU,
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
                                           arbitrary_frame_feedback_id);
   {
     // Kill A2 via session close (posts a task to disconnect, but A2 must not
     // be sent either of these two buffers).
     EXPECT_CALL(*client_a_, DoEnded(client_a_route_2)).Times(1);
     controller_->StopSession(200);
   }
   ASSERT_TRUE(buffer4.get());
   memset(buffer4->data(), buffer_no++, buffer4->mapped_size());
-  video_frame = WrapBuffer(capture_resolution,
-                           static_cast<uint8_t*>(buffer4->data()), format);
-  ASSERT_TRUE(video_frame);
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer4), video_frame);
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer4),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
   // B2 is the only client left, and is the only one that should
   // get the buffer.
-  EXPECT_CALL(*client_b_, DoBufferReady(client_b_route_2, capture_resolution))
+  EXPECT_CALL(*client_b_,
+              DoBufferReady(client_b_route_2, device_format.frame_size))
       .Times(2);
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
   Mock::VerifyAndClearExpectations(client_b_.get());
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         VideoCaptureControllerTest,
                         ::testing::Values(media::PIXEL_FORMAT_I420,
                                           media::PIXEL_FORMAT_Y16));
@@ skipping 18 matching lines @@
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
 
   // Second client connects after the error state. It also should get told of
   // the error.
   EXPECT_CALL(*client_b_, DoError(route_id)).Times(1);
   controller_->AddClient(route_id, client_b_.get(), 200, session_200);
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_b_.get());
 
-  const int arbitrary_frame_feedback_id = 101;
+  media::VideoCaptureFormat device_format(
+      capture_resolution, arbitrary_frame_rate_, media::PIXEL_FORMAT_I420,
+      media::PIXEL_STORAGE_CPU);
+    const int arbitrary_frame_feedback_id = 101;
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer(
-      device_client_->ReserveOutputBuffer(
-          capture_resolution, media::PIXEL_FORMAT_I420,
-          media::PIXEL_STORAGE_CPU, arbitrary_frame_feedback_id));
-  ASSERT_TRUE(buffer.get());
-  scoped_refptr<media::VideoFrame> video_frame =
-      WrapBuffer(capture_resolution, static_cast<uint8_t*>(buffer->data()));
-  ASSERT_TRUE(video_frame);
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer), video_frame);
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
+                                          arbitrary_frame_feedback_id));
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
 
   base::RunLoop().RunUntilIdle();
 }
 
 // Exercises the OnError() codepath of VideoCaptureController, and tests the
 // behavior of various operations after the error state has been signalled.
 TEST_F(VideoCaptureControllerTest, ErrorAfterDeviceCreation) {
   media::VideoCaptureParams session_100;
   session_100.requested_format = media::VideoCaptureFormat(
       gfx::Size(320, 240), 30, media::PIXEL_FORMAT_I420);
 
   media::VideoCaptureParams session_200 = session_100;
 
   const VideoCaptureControllerID route_id(0x99);
 
   // Start with one client.
   controller_->AddClient(route_id, client_a_.get(), 100, session_100);
-  media::VideoCaptureFormat device_format(
-      gfx::Size(10, 10), 25, media::PIXEL_FORMAT_ARGB);
 
   // Start the device. Then, before the first buffer, signal an error and
   // deliver the buffer. The error should be propagated to clients; the buffer
   // should not be.
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
 
-  const gfx::Size dims(320, 240);
+  media::VideoCaptureFormat device_format(
+      gfx::Size(10, 10), arbitrary_frame_rate_, media::PIXEL_FORMAT_I420);
   const int arbitrary_frame_feedback_id = 101;
   std::unique_ptr<media::VideoCaptureDevice::Client::Buffer> buffer(
-      device_client_->ReserveOutputBuffer(dims, media::PIXEL_FORMAT_I420,
-                                          media::PIXEL_STORAGE_CPU,
+      device_client_->ReserveOutputBuffer(device_format.frame_size,
+                                          device_format.pixel_format,
+                                          device_format.pixel_storage,
                                           arbitrary_frame_feedback_id));
   ASSERT_TRUE(buffer.get());
 
-  scoped_refptr<media::VideoFrame> video_frame =
-      WrapBuffer(dims, static_cast<uint8_t*>(buffer->data()));
-  ASSERT_TRUE(video_frame);
   device_client_->OnError(FROM_HERE, "Test Error");
-  video_frame->metadata()->SetTimeTicks(
-      media::VideoFrameMetadata::REFERENCE_TIME, base::TimeTicks());
-  device_client_->OnIncomingCapturedVideoFrame(std::move(buffer), video_frame);
+  device_client_->OnIncomingCapturedBuffer(std::move(buffer),
+    device_format,
+    arbitrary_reference_time_,
+    arbitrary_timestamp_);
 
   EXPECT_CALL(*client_a_, DoError(route_id)).Times(1);
   base::RunLoop().RunUntilIdle();
   Mock::VerifyAndClearExpectations(client_a_.get());
 
   // Second client connects after the error state. It also should get told of
   // the error.
   EXPECT_CALL(*client_b_, DoError(route_id)).Times(1);
   controller_->AddClient(route_id, client_b_.get(), 200, session_200);
   Mock::VerifyAndClearExpectations(client_b_.get());
 }
 
 }  // namespace content