 Chromium Code Reviews
 Chromium Code Reviews Issue 2592263003:
  Send an empty tooltip text when hovering over a different node  (Closed)
    
  
    Issue 2592263003:
  Send an empty tooltip text when hovering over a different node  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights | 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple, Inc. All rights | 
| 3 * reserved. | 3 * reserved. | 
| 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). | 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). | 
| 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. | 5 * Copyright (C) 2012 Samsung Electronics. All rights reserved. | 
| 6 * | 6 * | 
| 7 * This library is free software; you can redistribute it and/or | 7 * This library is free software; you can redistribute it and/or | 
| 8 * modify it under the terms of the GNU Library General Public | 8 * modify it under the terms of the GNU Library General Public | 
| 9 * License as published by the Free Software Foundation; either | 9 * License as published by the Free Software Foundation; either | 
| 10 * version 2 of the License, or (at your option) any later version. | 10 * version 2 of the License, or (at your option) any later version. | 
| (...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 330 | 330 | 
| 331 virtual std::unique_ptr<WebFrameScheduler> createFrameScheduler( | 331 virtual std::unique_ptr<WebFrameScheduler> createFrameScheduler( | 
| 332 BlameContext*) = 0; | 332 BlameContext*) = 0; | 
| 333 | 333 | 
| 334 // Returns the time of the beginning of the last beginFrame, in seconds, if | 334 // Returns the time of the beginning of the last beginFrame, in seconds, if | 
| 335 // any, and 0.0 otherwise. | 335 // any, and 0.0 otherwise. | 
| 336 virtual double lastFrameTimeMonotonic() const { return 0.0; } | 336 virtual double lastFrameTimeMonotonic() const { return 0.0; } | 
| 337 | 337 | 
| 338 virtual void installSupplements(LocalFrame&) {} | 338 virtual void installSupplements(LocalFrame&) {} | 
| 339 | 339 | 
| 340 DECLARE_TRACE(); | |
| 341 | |
| 340 protected: | 342 protected: | 
| 341 ~ChromeClient() override {} | 343 ~ChromeClient() override {} | 
| 342 | 344 | 
| 343 virtual void showMouseOverURL(const HitTestResult&) = 0; | 345 virtual void showMouseOverURL(const HitTestResult&) = 0; | 
| 344 virtual void setWindowRect(const IntRect&, LocalFrame&) = 0; | 346 virtual void setWindowRect(const IntRect&, LocalFrame&) = 0; | 
| 345 virtual bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, | 347 virtual bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, | 
| 346 bool isReload) = 0; | 348 bool isReload) = 0; | 
| 347 virtual bool openJavaScriptAlertDelegate(LocalFrame*, const String&) = 0; | 349 virtual bool openJavaScriptAlertDelegate(LocalFrame*, const String&) = 0; | 
| 348 virtual bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) = 0; | 350 virtual bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) = 0; | 
| 349 virtual bool openJavaScriptPromptDelegate(LocalFrame*, | 351 virtual bool openJavaScriptPromptDelegate(LocalFrame*, | 
| 350 const String& message, | 352 const String& message, | 
| 351 const String& defaultValue, | 353 const String& defaultValue, | 
| 352 String& result) = 0; | 354 String& result) = 0; | 
| 353 virtual void printDelegate(LocalFrame*) = 0; | 355 virtual void printDelegate(LocalFrame*) = 0; | 
| 354 | 356 | 
| 355 private: | 357 private: | 
| 356 bool canOpenModalIfDuringPageDismissal(Frame* mainFrame, | 358 bool canOpenModalIfDuringPageDismissal(Frame* mainFrame, | 
| 357 DialogType, | 359 DialogType, | 
| 358 const String& message); | 360 const String& message); | 
| 359 void setToolTip(LocalFrame&, const HitTestResult&); | 361 void setToolTip(LocalFrame&, const HitTestResult&); | 
| 360 | 362 | 
| 363 WeakMember<Node> m_lastMouseOverNode; | |
| 
Stephen Chennney
2017/01/03 20:38:25
Does this really need to be a weak pointer, rather
 | |
| 361 LayoutPoint m_lastToolTipPoint; | 364 LayoutPoint m_lastToolTipPoint; | 
| 362 String m_lastToolTipText; | 365 String m_lastToolTipText; | 
| 363 | 366 | 
| 364 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood); | 367 FRIEND_TEST_ALL_PREFIXES(ChromeClientTest, SetToolTipFlood); | 
| 365 }; | 368 }; | 
| 366 | 369 | 
| 367 } // namespace blink | 370 } // namespace blink | 
| 368 | 371 | 
| 369 #endif // ChromeClient_h | 372 #endif // ChromeClient_h | 
| OLD | NEW |