ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm - Issue 2592173002: Fix ios_chrome_unittests to crash on DCHECK failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

Issue 2592173002: Fix ios_chrome_unittests to crash on DCHECK failure. (Closed)

Patch Set: Address comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/metrics/first_user_action_recorder.cc ('k') | ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

diff --git a/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm b/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

index 4c942adaa4211b44eb051c7959b7d6561a6396ef..c02088a2af3ecd3b684417c3a1f798171d1a0abe 100644

--- a/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

+++ b/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

@@ -69,9 +69,7 @@ class MobileSessionShutdownMetricsProviderForTesting

class MobileSessionShutdownMetricsProviderTest

: public testing::TestWithParam<int> {

public:

- MobileSessionShutdownMetricsProviderTest()

- : task_runner_(new base::TestSimpleTaskRunner) {

- base::SetRecordActionTaskRunner(task_runner_);

+ MobileSessionShutdownMetricsProviderTest() {

metrics::MetricsService::RegisterPrefs(local_state_.registry());

}

@@ -82,7 +80,6 @@ class MobileSessionShutdownMetricsProviderTest

std::unique_ptr<metrics::MetricsService> metrics_service_;

std::unique_ptr<MobileSessionShutdownMetricsProviderForTesting>

metrics_provider_;

- scoped_refptr<base::SingleThreadTaskRunner> task_runner_;

private:

DISALLOW_COPY_AND_ASSIGN(MobileSessionShutdownMetricsProviderTest);