Issue 2592153002: GN: Make GN the default

Issue 2592153002: GN: Make GN the default (Closed)

Created:
3 years, 12 months ago by zra

Modified:
3 years, 12 months ago

Reviewers:
Bill Hesse, siva

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

GN: Make GN the default R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/ca864e93a1059c4533049832807034a9186dfe54

Patch Set 2 : Fix comment. Bump goma -j #

Total comments: 2

Patch Set 3 : Fix flag help. Switch GN FYI bot to gyp. #

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -21 lines)			Patch
M	tools/bots/gn_build.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/build.py	View	1 2	4 chunks	+8 lines, -8 lines	0 comments	Download
M	tools/generate_buildfiles.py	View	1	4 chunks	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

LGTM, with comment. https://codereview.chromium.org/2592153002/diff/20001/tools/build.py File tools/build.py (right): https://codereview.chromium.org/2592153002/diff/20001/tools/build.py#newcode88 tools/build.py:88: help='Build with GN/Ninja', The help comment ...

3 years, 12 months ago (2016-12-21 19:38:14 UTC) #3

zra

I also changed gn_build.py to use gyp so that even after this lands, we'll have ...

3 years, 12 months ago (2016-12-21 20:32:06 UTC) #4

zra

3 years, 12 months ago (2016-12-22 20:10:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
ca864e93a1059c4533049832807034a9186dfe54.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages