Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: components/ntp_snippets/features.cc

Issue 2592143003: Allow ObserverListThreadSafe to be used from sequenced tasks. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/features.h" 5 #include "components/ntp_snippets/features.h"
6 6
7 #include "base/memory/ptr_util.h"
7 #include "base/time/clock.h" 8 #include "base/time/clock.h"
8 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h " 9 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h "
9 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h" 10 #include "components/ntp_snippets/category_rankers/constant_category_ranker.h"
10 #include "components/variations/variations_associated_data.h" 11 #include "components/variations/variations_associated_data.h"
11 12
12 namespace ntp_snippets { 13 namespace ntp_snippets {
13 14
14 const base::Feature kArticleSuggestionsFeature{ 15 const base::Feature kArticleSuggestionsFeature{
15 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 16 "NTPArticleSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
16 17
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 return base::MakeUnique<ClickBasedCategoryRanker>(pref_service, 87 return base::MakeUnique<ClickBasedCategoryRanker>(pref_service,
87 std::move(clock)); 88 std::move(clock));
88 default: 89 default:
89 NOTREACHED() << "The category ranker choice value is " 90 NOTREACHED() << "The category ranker choice value is "
90 << static_cast<int>(choice); 91 << static_cast<int>(choice);
91 } 92 }
92 return nullptr; 93 return nullptr;
93 } 94 }
94 95
95 } // namespace ntp_snippets 96 } // namespace ntp_snippets
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698