Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 259213002: Ensure style resolver is created to avoid crash. (Closed)

Created:
6 years, 7 months ago by rune
Modified:
6 years, 7 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Inactive, ojan, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Ensure style resolver is created to avoid crash. The style resolver may be cleared by DOM modifications in event handlers prior to changing the :focus/:active/:hover state. Use ensureStyleResolver() instead of just styleResolver() to make sure its created to be able to schedule style invalidations. R=esprehn@chromium.org BUG=368017, 368026 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
A LayoutTests/fast/dynamic/focus-clear-resolver-crash.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/dynamic/focus-clear-resolver-crash-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 7 months ago (2014-04-29 09:11:01 UTC) #1
dglazkov
lgtm
6 years, 7 months ago (2014-04-29 14:31:18 UTC) #2
rune
The CQ bit was checked by rune@opera.com
6 years, 7 months ago (2014-04-29 15:07:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/259213002/1
6 years, 7 months ago (2014-04-29 15:07:29 UTC) #4
rune
The CQ bit was unchecked by rune@opera.com
6 years, 7 months ago (2014-04-29 20:11:36 UTC) #5
rune
The CQ bit was checked by rune@opera.com
6 years, 7 months ago (2014-04-29 20:11:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/259213002/1
6 years, 7 months ago (2014-04-29 20:26:50 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:57:26 UTC) #8
Message was sent while issue was closed.
Change committed as 172907

Powered by Google App Engine
This is Rietveld 408576698