third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js - Issue 2592113003: Load data URI images in an async way according to spec (take 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

Issue 2592113003: Load data URI images in an async way according to spec (take 3) (Closed)

Patch Set: Fixed more devtools reliance on sync loading Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js ('k') | third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

index 5408a32cd8c7932f6772ff46589645b17ff50b53..767c996ce562e190fe7f0fa27e36ad6888ecfb32 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js

@@ -465,13 +465,12 @@ Timeline.TimelineFilmStripOverview = class extends Timeline.TimelineEventOvervie

var promise = new Promise(f => fulfill = f);

var image = /** @type {!HTMLImageElement} */ (createElement('img'));

- if (data)

+ if (data) {

image.src = 'data:image/jpg;base64,' + data;

- if (image.complete) {

- fulfill(image);

- } else {

image.addEventListener('load', () => fulfill(image));

image.addEventListener('error', () => fulfill(image));

+ } else {

+ fulfill(image);

}

return promise;

}