Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6965)

Unified Diff: chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js

Issue 2592113003: Load data URI images in an async way according to spec (take 3) (Closed)
Patch Set: Fixed more devtools reliance on sync loading Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
diff --git a/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js b/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
index 6b1c47f073ed8d20d1a5a8c81f7b8ac84cf0aae2..d98296ef7651cc6160ae3de79e240792a1302bba 100644
--- a/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
+++ b/chrome/test/data/extensions/api_test/automation/tests/tabs/image_data.js
@@ -13,37 +13,39 @@ var allTests = [
canvas.setAttribute('width', 2);
canvas.setAttribute('height', 3);
var context = canvas.getContext('2d');
- context.drawImage(imgElement, 0, 0);
- var imageData = context.getImageData(0, 0, 2, 3);
- // Check image data in RGBA format.
- // Top row: red
- assertEq(imageData.data[0], 0xFF);
- assertEq(imageData.data[1], 0x00);
- assertEq(imageData.data[2], 0x00);
- assertEq(imageData.data[3], 0xFF);
- assertEq(imageData.data[4], 0xFF);
- assertEq(imageData.data[5], 0x00);
- assertEq(imageData.data[6], 0x00);
- assertEq(imageData.data[7], 0xFF);
- // Middle row: green
- assertEq(imageData.data[8], 0x00);
- assertEq(imageData.data[9], 0xFF);
- assertEq(imageData.data[10], 0x00);
- assertEq(imageData.data[11], 0xFF);
- assertEq(imageData.data[12], 0x00);
- assertEq(imageData.data[13], 0xFF);
- assertEq(imageData.data[14], 0x00);
- assertEq(imageData.data[15], 0xFF);
- // Last row: blue
- assertEq(imageData.data[16], 0x00);
- assertEq(imageData.data[17], 0x00);
- assertEq(imageData.data[18], 0xFF);
- assertEq(imageData.data[19], 0xFF);
- assertEq(imageData.data[20], 0x00);
- assertEq(imageData.data[21], 0x00);
- assertEq(imageData.data[22], 0xFF);
- assertEq(imageData.data[23], 0xFF);
- chrome.test.succeed();
+ imgElement.onload = function() {
+ context.drawImage(imgElement, 0, 0);
+ var imageData = context.getImageData(0, 0, 2, 3);
+ // Check image data in RGBA format.
+ // Top row: red
+ assertEq(imageData.data[0], 0xFF);
+ assertEq(imageData.data[1], 0x00);
+ assertEq(imageData.data[2], 0x00);
+ assertEq(imageData.data[3], 0xFF);
+ assertEq(imageData.data[4], 0xFF);
+ assertEq(imageData.data[5], 0x00);
+ assertEq(imageData.data[6], 0x00);
+ assertEq(imageData.data[7], 0xFF);
+ // Middle row: green
+ assertEq(imageData.data[8], 0x00);
+ assertEq(imageData.data[9], 0xFF);
+ assertEq(imageData.data[10], 0x00);
+ assertEq(imageData.data[11], 0xFF);
+ assertEq(imageData.data[12], 0x00);
+ assertEq(imageData.data[13], 0xFF);
+ assertEq(imageData.data[14], 0x00);
+ assertEq(imageData.data[15], 0xFF);
+ // Last row: blue
+ assertEq(imageData.data[16], 0x00);
+ assertEq(imageData.data[17], 0x00);
+ assertEq(imageData.data[18], 0xFF);
+ assertEq(imageData.data[19], 0xFF);
+ assertEq(imageData.data[20], 0x00);
+ assertEq(imageData.data[21], 0x00);
+ assertEq(imageData.data[22], 0xFF);
+ assertEq(imageData.data[23], 0xFF);
+ chrome.test.succeed();
+ };
}, true);
image.getImageData(0, 0);
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-out-of-bounds-src.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698