Issue 2592083002: VM: Clear all *_to_retain maps when resetting the precompiler state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2592083002: VM: Clear all *_to_retain maps when resetting the precompiler state (Closed)

Created:
3 years, 12 months ago by kustermann

Modified:
3 years, 12 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Clear all *_to_retain maps when resetting the precompiler state We often do work when adding entries to these maps but when entries already exist we skip the work. When running the precompiler multiple times we should clear the maps to ensure we always to the necessary work. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/b8d549e7598c8ac10d261f800ac1af85158d5cb5

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	runtime/vm/precompiler.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

kustermann

3 years, 12 months ago (2016-12-22 10:47:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b8d549e7598c8ac10d261f800ac1af85158d5cb5 (presubmit successful).