Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 259203002: Add missing length check when copying fixed arrays. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Add missing length check when copying fixed arrays. This was mistakenly removed in r21027. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
6 years, 7 months ago (2014-04-29 08:23:22 UTC) #1
Yang
On 2014/04/29 08:23:22, Yang wrote: See https://codereview.chromium.org/256993003/diff/20001/src/objects-inl.h
6 years, 7 months ago (2014-04-29 08:23:43 UTC) #2
Benedikt Meurer
LGTM
6 years, 7 months ago (2014-04-29 08:24:20 UTC) #3
Yang
6 years, 7 months ago (2014-04-29 08:25:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698