Update TaskTraits in recovery_component_installer.cc.

chrome/browser/component_updater/recovery_component_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/recovery_component_installer.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
@@ skipping 206 matching lines @@
   // The child process must print its PID in the first line of its STDOUT. See
   // https://cs.chromium.org/chromium/src/base/mac/authorization_util.h?l=8
   // for more details. When |pid| cannot be determined, we are not able to
   // get process exit code, thus bail out early.
   if (pid < 0) {
     RecordRecoveryComponentUMAEvent(RCE_ELEVATED_UNKNOWN_RESULT);
     return;
   }
   base::Process process = base::Process::Open(pid);
 #endif
+  // This task joins a process, hence .WithSyncPrimitives().
   base::PostTaskWithTraits(
       FROM_HERE, base::TaskTraits()
                      .WithShutdownBehavior(
                          base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
                      .WithPriority(base::TaskPriority::BACKGROUND)
-                     .WithWait(),
+                     .WithSyncPrimitives(),
       base::Bind(&WaitForElevatedInstallToComplete, base::Passed(&process)));
 }
 
 void ElevatedInstallRecoveryComponent(const base::FilePath& installer_path) {
   base::PostTaskWithTraits(
       FROM_HERE, base::TaskTraits()
                      .WithShutdownBehavior(
                          base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
                      .WithPriority(base::TaskPriority::BACKGROUND)
-                     .WithFileIO(),
+                     .MayBlock(),
       base::Bind(&DoElevatedInstallRecoveryComponent, installer_path));
 }
 #endif  // defined(OS_WIN)
 
 }  // namespace
 
 // Component installer that is responsible to repair the chrome installation
 // or repair the Google update installation. This is a last resort safety
 // mechanism.
 // For user Chrome, recovery component just installs silently. For machine
@@ skipping 111 matching lines @@
 
   base::LaunchOptions options;
 #if defined(OS_WIN)
   options.start_hidden = true;
 #endif
   base::Process process = base::LaunchProcess(cmdline, options);
   if (!process.IsValid())
     return false;
 
   // Let worker pool thread wait for us so we don't block Chrome shutdown.
+  // This task joins a process, hence .WithSyncPrimitives().
   base::PostTaskWithTraits(
       FROM_HERE, base::TaskTraits()
                      .WithShutdownBehavior(
                          base::TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN)
                      .WithPriority(base::TaskPriority::BACKGROUND)
-                     .WithWait(),
+                     .WithSyncPrimitives(),
       base::Bind(&WaitForInstallToComplete, base::Passed(&process),
                  installer_folder, prefs_));
 
   // Returns true regardless of install result since from updater service
   // perspective the install is done, even we may need to do elevated
   // install later.
   return true;
 }
 #else
 bool RecoveryComponentInstaller::RunInstallCommand(
@@ skipping 135 matching lines @@
 #endif  // OS_WIN
   prefs->SetBoolean(prefs::kRecoveryComponentNeedsElevation, false);
 }
 
 void DeclinedElevatedRecoveryInstall(PrefService* prefs) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   prefs->SetBoolean(prefs::kRecoveryComponentNeedsElevation, false);
 }
 
 }  // namespace component_updater