Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259183003: Disable sounds in the virtual keyboard. (Closed)

Created:
6 years, 7 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Disable sounds in the virtual keyboard. BUG=368255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267085

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ui/keyboard/resources/constants.js View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
rsadam
PTAL!
6 years, 7 months ago (2014-04-29 15:30:15 UTC) #1
bshe
On 2014/04/29 15:30:15, rsadam wrote: > PTAL! lgtm
6 years, 7 months ago (2014-04-29 15:32:11 UTC) #2
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-29 15:32:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/259183003/20001
6 years, 7 months ago (2014-04-29 15:33:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 16:24:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 16:24:04 UTC) #6
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-29 19:06:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/259183003/20001
6 years, 7 months ago (2014-04-29 19:08:17 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:44:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:44:19 UTC) #10
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-04-29 21:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/259183003/20001
6 years, 7 months ago (2014-04-29 21:47:52 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:26:07 UTC) #13
Message was sent while issue was closed. 
Change committed as 267085

Powered by Google App Engine
This is Rietveld 408576698