Run angle_perftests on the GPU FYI bots.

content/test/gpu/generate_buildbot_json.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to generate chromium.gpu.json and chromium.gpu.fyi.json in
 the src/testing/buildbot directory. Maintaining these files by hand is
 too unwieldy.
 """
 
@@ skipping 1345 matching lines @@
       '../../content/test/data/gpu/webgl2_conformance_tests_output.json',
     ],
     'swarming': {
       # These tests currently take about an hour and fifteen minutes
       # to run. Split them into roughly 5-minute shards.
       'shards': 15,
     },
   },
 }
 
+# These isolated tests don't use telemetry. They need to be placed in the
+# isolated_scripts section of the generated json.
+NON_TELEMETRY_ISOLATED_SCRIPT_TESTS = {
+  # We run angle_perftests on the ANGLE CQ to ensure the tests don't crash.
+  'angle_perftests': {
+    'tester_configs': [
+      {
+        'fyi_only': True,
+        'run_on_optional': True,
+        # Run on the Win/Linux Release NVIDIA bots.
+        'build_configs': ['Release'],
+        'swarming_dimension_sets': [
+          {
+            'gpu': '10de:104a',
+            'os': 'Windows-2008ServerR2-SP1'
+          },
+          {
+            'gpu': '10de:104a',
+            'os': 'Linux'
+          }
+        ],
+      },
+    ],
+  },
+}
+
 def substitute_args(tester_config, args):
   """Substitutes the ${os_type} variable in |args| from the
      tester_config's "os_type" property.
   """
   substitutions = {
     'os_type': tester_config['os_type']
   }
   return [string.Template(arg).safe_substitute(substitutions) for arg in args]
 
 def matches_swarming_dimensions(tester_config, dimension_sets):
@@ skipping 213 matching lines @@
 def generate_telemetry_tests(tester_name, tester_config,
                              test_dictionary, is_fyi):
   isolated_scripts = []
   for test_name, test_config in sorted(test_dictionary.iteritems()):
     test = generate_telemetry_test(
       tester_name, tester_config, test_name, test_config, is_fyi)
     if test:
       isolated_scripts.append(test)
   return isolated_scripts
 
+def generate_non_telemetry_isolated_test(tester_name, tester_config,

[Ken Russell (switch to Gerrit), 2017/01/10 00:22:34]

Could you add a TODO about refactoring this and generate_telemetry_test? There
could be a base function "generate_isolated_test" which takes in the additional
information that generate_telemetry_test computes (like
extra_browser_args_string and the isolate name), and both this one and the other
could call it, reducing duplicated code.

+                                         test, test_config, is_fyi):
+  if not should_run_on_tester(tester_name, tester_config, test_config, is_fyi):
+    return None
+  test_args = ['-v']
+  if 'args' in test_config:
+    test_args.extend(substitute_args(tester_config, test_config['args']))
+  if 'desktop_args' in test_config and not is_android(tester_config):
+    test_args.extend(substitute_args(tester_config,
+                                     test_config['desktop_args']))
+  if 'android_args' in test_config and is_android(tester_config):
+    test_args.extend(substitute_args(tester_config,
+                                     test_config['android_args']))
+  # The step name must end in 'test' or 'tests' in order for the
+  # results to automatically show up on the flakiness dashboard.
+  # (At least, this was true some time ago.) Continue to use this
+  # naming convention for the time being to minimize changes.
+  step_name = test
+  if not (step_name.endswith('test') or step_name.endswith('tests')):
+    step_name = '%s_tests' % step_name
+  # Prepend Telemetry GPU-specific flags.

[Ken Russell (switch to Gerrit), 2017/01/10 00:22:33]

Update: "Prepend GPU-specific flags."

+  swarming = {
+    # Always say this is true regardless of whether the tester
+    # supports swarming. It doesn't hurt.
+    'can_use_on_swarming_builders': True,
+    'dimension_sets': tester_config['swarming_dimensions']
+  }
+  if 'swarming' in test_config:
+    swarming.update(test_config['swarming'])
+  result = {
+    'args': test_args,
+    'isolate_name': test,
+    'name': step_name,
+    'swarming': swarming,
+  }
+  if 'non_precommit_args' in test_config:
+    result['non_precommit_args'] = test_config['non_precommit_args']
+  if 'precommit_args' in test_config:
+    result['precommit_args'] = test_config['precommit_args']
+  return result
+
+def generate_non_telemetry_isolated_tests(tester_name, tester_config,
+                                          test_dictionary, is_fyi):
+  isolated_scripts = []
+  for test_name, test_config in sorted(test_dictionary.iteritems()):
+    test = generate_non_telemetry_isolated_test(
+      tester_name, tester_config, test_name, test_config, is_fyi)
+    if test:
+      isolated_scripts.append(test)
+  return isolated_scripts
+
 def generate_all_tests(waterfall, is_fyi):
   tests = {}
   for builder, config in waterfall['builders'].iteritems():
     tests[builder] = config
   for name, config in waterfall['testers'].iteritems():
     gtests = generate_gtests(name, config, COMMON_GTESTS, is_fyi)
     isolated_scripts = \
       generate_telemetry_tests(
-        name, config, TELEMETRY_GPU_INTEGRATION_TESTS, is_fyi)
+        name, config, TELEMETRY_GPU_INTEGRATION_TESTS, is_fyi) + \
+      generate_non_telemetry_isolated_tests(name, config,
+          NON_TELEMETRY_ISOLATED_SCRIPT_TESTS, is_fyi)
     tests[name] = {
       'gtest_tests': sorted(gtests, key=lambda x: x['test']),
       'isolated_scripts': sorted(isolated_scripts, key=lambda x: x['name'])
     }
   tests['AAAAA1 AUTOGENERATED FILE DO NOT EDIT'] = {}
   tests['AAAAA2 See generate_buildbot_json.py to make changes'] = {}
   filename = 'chromium.gpu.fyi.json' if is_fyi else 'chromium.gpu.json'
   with open(os.path.join(SRC_DIR, 'testing', 'buildbot', filename), 'wb') as fp:
     json.dump(tests, fp, indent=2, separators=(',', ': '), sort_keys=True)
     fp.write('\n')
 
 def main():
   generate_all_tests(FYI_WATERFALL, True)
   generate_all_tests(WATERFALL, False)
   return 0
 
 if __name__ == "__main__":
   sys.exit(main())