Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: cc/scheduler/begin_frame_source.cc

Issue 2591773002: [cc] BackToBackBFS: Disable time source if all pending observers removed (Closed)
Patch Set: add DCHECK Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/begin_frame_source.cc
diff --git a/cc/scheduler/begin_frame_source.cc b/cc/scheduler/begin_frame_source.cc
index 30916948cec360b751b158e69316c4e6617f8b3b..4c859a7b53c89c81a0aa8ee738ecc0d806607600 100644
--- a/cc/scheduler/begin_frame_source.cc
+++ b/cc/scheduler/begin_frame_source.cc
@@ -77,7 +77,7 @@ void BackToBackBeginFrameSource::RemoveObserver(BeginFrameObserver* obs) {
DCHECK(observers_.find(obs) != observers_.end());
observers_.erase(obs);
pending_begin_frame_observers_.erase(obs);
- if (observers_.empty())
+ if (pending_begin_frame_observers_.empty())
time_source_->SetActive(false);
}
@@ -105,6 +105,7 @@ void BackToBackBeginFrameSource::OnTimerTick() {
std::unordered_set<BeginFrameObserver*> pending_observers;
pending_observers.swap(pending_begin_frame_observers_);
+ DCHECK(!pending_observers.empty());
for (BeginFrameObserver* obs : pending_observers)
obs->OnBeginFrame(args);
}
« no previous file with comments | « no previous file | cc/scheduler/begin_frame_source_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698