test/cctest/test-serialize.cc - Issue 259173003: Kiss goodbye to MaybeObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-serialize.cc

Issue 259173003: Kiss goodbye to MaybeObject. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebase + addressed comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-serialize.cc

diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc

index 16fcb58803744d58cddcf418eb5dc016a2e86a73..10c35c1c4d64277ccbf130676a4a6dcae0a5d523 100644

--- a/test/cctest/test-serialize.cc

+++ b/test/cctest/test-serialize.cc

@@ -297,8 +297,7 @@ static void SanityCheck() {

CHECK(isolate->global_object()->IsJSObject());

CHECK(isolate->native_context()->IsContext());

CHECK(CcTest::heap()->string_table()->IsStringTable());

- CHECK(!isolate->factory()->InternalizeOneByteString(

- STATIC_ASCII_VECTOR("Empty"))->IsFailure());

+ isolate->factory()->InternalizeOneByteString(STATIC_ASCII_VECTOR("Empty"));

}

« no previous file with comments | « test/cctest/test-mark-compact.cc ('k') | test/cctest/test-spaces.cc » ('j') | no next file with comments »