Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2591673002: [NTP::PhysicalWeb] Do not show published time. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
index b7eae7f106901cb7d954a8bc3c683c957a498909..709f2d669637a7807df24b99700cc8cc79249b07 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
@@ -242,10 +242,7 @@ PhysicalWebPageSuggestionsProvider::GetMostRecentPhysicalWebPagesWithFilter(
ContentSuggestion PhysicalWebPageSuggestionsProvider::ConvertPhysicalWebPage(
const DictionaryValue& page) const {
std::string scanned_url, raw_resolved_url, title, description;
- int scan_timestamp;
bool success = page.GetString(physical_web::kScannedUrlKey, &scanned_url);
- success = page.GetInteger(physical_web::kScanTimestampKey, &scan_timestamp) &&
- success;
success = page.GetString(physical_web::kResolvedUrlKey, &raw_resolved_url) &&
success;
success = page.GetString(physical_web::kTitleKey, &title) && success;
@@ -260,10 +257,6 @@ ContentSuggestion PhysicalWebPageSuggestionsProvider::ConvertPhysicalWebPage(
resolved_url);
DCHECK(base::IsStringUTF8(title));
suggestion.set_title(base::UTF8ToUTF16(title));
- // TODO(vitaliii): Set the time properly once the proper value is provided
- // (see crbug.com/667722).
- suggestion.set_publish_date(
- base::Time::FromTimeT(static_cast<time_t>(scan_timestamp)));
suggestion.set_publisher_name(base::UTF8ToUTF16(resolved_url.host()));
DCHECK(base::IsStringUTF8(description));
suggestion.set_snippet_text(base::UTF8ToUTF16(description));

Powered by Google App Engine
This is Rietveld 408576698