[NTP::PhysicalWeb] Do not show published time.

chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.snippets;
 
 import android.annotation.SuppressLint;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
 import android.graphics.drawable.BitmapDrawable;
@@ skipping 32 matching lines @@
 
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.concurrent.TimeUnit;
 
 /**
  * A class that represents the view for a single card snippet.
  */
 public class SnippetArticleViewHolder
         extends CardViewHolder implements ImpressionTracker.Listener, ContextMenuManager.Delegate {
-    private static final String PUBLISHER_FORMAT_STRING = "%s - %s";
+    private static final String PUBLISHER_FORMAT_STRING = "%s%s";

[dgn, 2016/12/20 11:15:39]

that's kind of icky... how about something like this instead:


String getAttributionString(SnippetArticle article) {
  if (article.mPublishTimestampMs == 0) return article.mPublisher;
  
  // Then try/finally with strict mode stuff to get the relative timestring

  // then bi-di formatting, since when you only have the publisher you don't
need that
}

mPublisherTextView.setText(getAttributionString(mArticle));

+    private static final String PUBLISHED_TIME_FORMAT_STRING = " - %s";
     private static final int FADE_IN_ANIMATION_TIME_MS = 300;
     private static final int[] FAVICON_SERVICE_SUPPORTED_SIZES = {16, 24, 32, 48, 64};
     private static final String FAVICON_SERVICE_FORMAT =
             "https://s2.googleusercontent.com/s2/favicons?domain=%s&src=chrome_newtab_mobile&sz=%d&alt=404";
 
     private final NewTabPageManager mNewTabPageManager;
     private final TextView mHeadlineTextView;
     private final TextView mPublisherTextView;
     private final TextView mArticleSnippetTextView;
     private final ImageView mThumbnailView;
@@ skipping 132 matching lines @@
         updateLayout();
 
         mHeadlineTextView.setText(mArticle.mTitle);
 
         // DateUtils.getRelativeTimeSpanString(...) calls through to TimeZone.getDefault(). If this
         // has never been called before it loads the current time zone from disk. In most likelihood
         // this will have been called previously and the current time zone will have been cached,
         // but in some cases (eg instrumentation tests) it will cause a strict mode violation.
         StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
         try {
+            String relativeTimeString = "";
             long time = SystemClock.elapsedRealtime();
-            CharSequence relativeTimeSpan = DateUtils.getRelativeTimeSpanString(
-                    mArticle.mPublishTimestampMilliseconds, System.currentTimeMillis(),
-                    DateUtils.MINUTE_IN_MILLIS);
+            if (mArticle.mPublishTimestampMilliseconds != 0) {
+                CharSequence relativeTimeSpan =
+                        DateUtils.getRelativeTimeSpanString(mArticle.mPublishTimestampMilliseconds,
+                                System.currentTimeMillis(), DateUtils.MINUTE_IN_MILLIS);
+                relativeTimeString = String.format(PUBLISHED_TIME_FORMAT_STRING, relativeTimeSpan);
+            }
             RecordHistogram.recordTimesHistogram("Android.StrictMode.SnippetUIBuildTime",
                     SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
 
             // We format the publisher here so that having a publisher name in an RTL language
             // doesn't mess up the formatting on an LTR device and vice versa.
             String publisherAttribution = String.format(PUBLISHER_FORMAT_STRING,
-                    BidiFormatter.getInstance().unicodeWrap(mArticle.mPublisher), relativeTimeSpan);
+                    BidiFormatter.getInstance().unicodeWrap(mArticle.mPublisher),
+                    relativeTimeString);
             mPublisherTextView.setText(publisherAttribution);
         } finally {

[dgn, 2016/12/20 11:15:39]

nit: why is the try/finally that big? shouldn't it only wrap the
getRelativeTimespan String?

[PEConn, 2016/12/20 11:24:07]

That is the only part that can fail, but if it does then there's no sense
executing the rest of the try block. I guess we could do:

String relativeTimeSpan = "";
try {
  relativeTimeSpan = DateUtils.getRelativeTimeSpanString(...)
} finally {
  ...
}

// use relativeTimeSpan

             StrictMode.setThreadPolicy(oldPolicy);
         }
 
         // The favicon of the publisher should match the TextView height.
         int widthSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
         int heightSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
         mPublisherTextView.measure(widthSpec, heightSpec);
         mPublisherFaviconSizePx = mPublisherTextView.getMeasuredHeight();
 
         mArticleSnippetTextView.setText(mArticle.mPreviewText);
@@ skipping 158 matching lines @@
         ApiCompatibilityUtils.setCompoundDrawablesRelative(
                 mPublisherTextView, drawable, null, null, null);
         mPublisherTextView.setVisibility(View.VISIBLE);
     }
 
     @Override
     public boolean isDismissable() {
         return !isPeeking();
     }
 }