third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html - Issue 2591623002: CSS Transition: Fix flaky opacity-transition-zindex.html

Unified Diff: third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html

Issue 2591623002: CSS Transition: Fix flaky opacity-transition-zindex.html (Closed)

Patch Set: png Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/virtual/threaded/transitions/opacity-transition-zindex-expected.png ('k') | third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex-expected.png » ('j') | third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html

diff --git a/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html b/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html

index 7dafbdd0e31e68a1358d11c7c61b9cb0856fef00..4c7313e14f96b4ba5035b409fb1061e607720f85 100644

--- a/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html

+++ b/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html

@@ -3,6 +3,11 @@

<html>

<head>

<style>

+ * {

suzyh_UTC10 (ex-contributor) 2016/12/21 00:37:45 What is the purpose of adding this clause?

Eric Willigers 2016/12/21 01:22:36 The test expectations previously depended on the f

+ border: 0;

+ margin: 0;

+ padding: 0;

+ }

.container {

suzyh_UTC10 (ex-contributor) 2016/12/21 00:37:45 Why are there separate .container and #first claus

Eric Willigers 2016/12/21 01:51:12 Now consolidated. There is no need for .class when

position: relative;

height: 300px;

@@ -41,6 +46,11 @@

if (window.testRunner)

testRunner.waitUntilDone();

+ function waitForCompositor() {

+ var box = document.getElementById('box');

+ return box.animate({transform: ['scale(1)', 'scale(1)']}, 1).ready;

+ }

function runTest()

{

var container = document.getElementById('first');

@@ -52,7 +62,9 @@

window.internals.pauseAnimations(2.5);

}

if (window.testRunner) {

+ waitForCompositor().then(() => {

testRunner.notifyDone();

+ });

}

// FIXME: this should use runTransitionTest().

@@ -62,7 +74,7 @@

<body>

- <div class="box"></div>

+ <div class="box" id="box"></div>

</div>