Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 259153004: Password bubble: Give users the option of unblacklisting a site. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 9f9c3687ac8bdb98816bb8382295a544f35fbb65..37938650373804e2c467d99420ac2b60ada07df4 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -36,13 +36,19 @@ class PasswordManagerClient {
// that this form doesn't need to be saved.
virtual void PromptUserToSavePassword(PasswordFormManager* form_to_save) = 0;
- // Called when a password is autofilled. Default implementation is a no-op.
+ // Called when a password is autofilled. |best_matches| contains the
+ // PasswordForm into which a password was filled: the client may choose to
+ // save this to the PasswordStore, for example. Default implementation is a
+ // noop.
virtual void PasswordWasAutofilled(
const autofill::PasswordFormMap& best_matches) const {}
- // Called when password autofill is blocked by the blacklist. Default
- // implementation is a no-op.
- virtual void PasswordAutofillWasBlocked() const {}
+ // Called when password autofill is blocked by the blacklist. |best_matches|
+ // contains the PasswordForm that flags the current site as being on the
+ // blacklist. The client may choose to remove this from the PasswordStore in
+ // order to unblacklist a site, for example. Default implementation is a noop.
+ virtual void PasswordAutofillWasBlocked(
+ const autofill::PasswordFormMap& best_matches) const {}
// Called to authenticate the autofill password data. If authentication is
// successful, this should continue filling the form.

Powered by Google App Engine
This is Rietveld 408576698