Fuchsia: Adds File::Copy()

Fuchsia: Adds File::Copy()

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/1f99052303c6f1bd2a04fd063ac9770ecc03ce38

[zra, 2016-12-19 20:29:01]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2016-12-19 20:29:02]

https://codereview.chromium.org/2591523002/diff/1/runtime/bin/file_fuchsia.cc
File runtime/bin/file_fuchsia.cc (right):

https://codereview.chromium.org/2591523002/diff/1/runtime/bin/file_fuchsia.cc...
runtime/bin/file_fuchsia.cc:285: if (type == kIsFile) {
This is copied from the Linux implementation with the attempt to use sendfile()
removed.

[siva, 2016-12-20 00:04:22]

lgtm

https://codereview.chromium.org/2591523002/diff/1/runtime/tests/vm/dart/hello...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2591523002/diff/1/runtime/tests/vm/dart/hello...
runtime/tests/vm/dart/hello_fuchsia_test.dart:412: List<int> data = [1, 2, 3, 4,
5, 6, 7, 8, 9, 10];
I think we should make this data bigger (potentially > 8k) to ensure we trigger
at least two iterations in the copy loop.

[zra, 2016-12-20 17:43:58]

https://codereview.chromium.org/2591523002/diff/1/runtime/tests/vm/dart/hello...
File runtime/tests/vm/dart/hello_fuchsia_test.dart (right):

https://codereview.chromium.org/2591523002/diff/1/runtime/tests/vm/dart/hello...
runtime/tests/vm/dart/hello_fuchsia_test.dart:412: List<int> data = [1, 2, 3, 4,
5, 6, 7, 8, 9, 10];
On 2016/12/20 00:04:22, siva wrote:
> I think we should make this data bigger (potentially > 8k) to ensure we
trigger
> at least two iterations in the copy loop.

Changed to 10KB.

[zra, 2016-12-20 17:44:11]

Description was changed from

==========
Fuchsia: Adds File::Copy()
==========

to

==========
Fuchsia: Adds File::Copy()

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1f99052303c6f1bd2a04fd063ac9770ecc03ce38
==========

[zra, 2016-12-20 17:44:12]

Committed patchset #2 (id:20001) manually as
1f99052303c6f1bd2a04fd063ac9770ecc03ce38 (presubmit successful).