Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: customtabs/src/android/support/customtabs/PostMessageService.java

Issue 2591513002: Add a service to handle postMessage callbacks to client (Closed)
Patch Set: Made CustomTabsCallback purely synchronized Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: customtabs/src/android/support/customtabs/PostMessageService.java
diff --git a/customtabs/src/android/support/customtabs/PostMessageService.java b/customtabs/src/android/support/customtabs/PostMessageService.java
new file mode 100644
index 0000000000000000000000000000000000000000..2b2c594d7d862b079b585352bffd41d2cc88662b
--- /dev/null
+++ b/customtabs/src/android/support/customtabs/PostMessageService.java
@@ -0,0 +1,57 @@
+/*
+ * Copyright (C) 2015 The Android Open Source Project
Benoit L 2017/01/25 17:36:46 nit: date?
Yusuf 2017/01/25 22:02:00 Done.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package android.support.customtabs;
+
+import android.app.Service;
+import android.content.Intent;
+import android.net.Uri;
Benoit L 2017/01/25 21:25:03 nit: not needed.
Yusuf 2017/01/25 22:02:00 Done.
+import android.os.Bundle;
+import android.os.IBinder;
Benoit L 2017/01/25 21:25:03 nit: not needed.
Yusuf 2017/01/25 22:02:00 Done.
+import android.os.IBinder.DeathRecipient;
+import android.os.RemoteException;
+import android.support.annotation.IntDef;
+import android.support.v4.util.ArrayMap;
Benoit L 2017/01/25 21:25:03 dittp for the 4 imports above.
Yusuf 2017/01/25 22:02:01 Done.
+
+import java.util.List;
+import java.util.Map;
+import java.util.NoSuchElementException;
Benoit L 2017/01/25 21:25:03 none of these imports are needed.
Yusuf 2017/01/25 22:02:00 Done.
+
+/**
+ * A service to receive postMessage related communication from a Custom Tabs provider.
+ */
+ public class PostMessageService extends Service {
+
+ private IPostMessageService.Stub mBinder = new IPostMessageService.Stub() {
+
+ @Override
+ public void onMessageChannelReady(
+ ICustomTabsCallback callback, Bundle extras) throws RemoteException {
+ callback.onMessageChannelReady(extras);
Benoit L 2017/01/25 21:25:03 nit: This is indented too much (4 extra spaces)
Yusuf 2017/01/25 22:02:00 Done.
+ }
+
+ @Override
+ public void onPostMessage(ICustomTabsCallback callback,
+ String message, Bundle extras) throws RemoteException {
+ callback.onPostMessage(message, extras);
+ }
+ };
+
+ @Override
+ public IBinder onBind(Intent intent) {
+ return mBinder;
+ }
+ }

Powered by Google App Engine
This is Rietveld 408576698