Fuchsia: implement Process::Wait() for Process.runSync()

Fuchsia: implement Process::Wait() for Process.runSync()

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/918b90ba460e82c4095e7fe9eb0c703500f8721b

[zra, 2016-12-19 23:18:40]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-12-20 00:45:40]

lgtm

https://codereview.chromium.org/2591473004/diff/20001/runtime/bin/process_fuc...
File runtime/bin/process_fuchsia.cc (right):

https://codereview.chromium.org/2591473004/diff/20001/runtime/bin/process_fuc...
runtime/bin/process_fuchsia.cc:452: Allocate();
This implementation seems to ignore OOM errors here.

Since we keep accumulating the output into this buffer list there is
a possibility that we may end up with an OOM and a potential for crashes (the
linux implementation has the same issue).

[zra, 2016-12-20 17:13:44]

https://codereview.chromium.org/2591473004/diff/20001/runtime/bin/process_fuc...
File runtime/bin/process_fuchsia.cc (right):

https://codereview.chromium.org/2591473004/diff/20001/runtime/bin/process_fuc...
runtime/bin/process_fuchsia.cc:452: Allocate();
On 2016/12/20 00:45:40, siva wrote:
> This implementation seems to ignore OOM errors here.
> 
> Since we keep accumulating the output into this buffer list there is
> a possibility that we may end up with an OOM and a potential for crashes (the
> linux implementation has the same issue).

At the moment there's a FATAL in the constructor of BufferListNode in process.h,
but I could change this to bubble ENOMEM up to the caller in an OSError.

I've also discovered a memory leak in the BufferList. It won't free its memory
if the read fails, so I'm going to address the OOM and the leak in my next CL.

[zra, 2016-12-20 17:30:04]

Description was changed from

==========
Fuchsia: implement Process::Wait() for Process.runSync()
==========

to

==========
Fuchsia: implement Process::Wait() for Process.runSync()

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/918b90ba460e82c4095e7fe9eb0c703500f8721b
==========

[zra, 2016-12-20 17:30:06]

Committed patchset #2 (id:20001) manually as
918b90ba460e82c4095e7fe9eb0c703500f8721b (presubmit successful).