Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

Issue 2591373003: Changed WritingMode to an enum class and renamed its members (Closed)
Patch Set: Added comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
index be433103fad5f4fb77e963be93e1e52b763c9104..ac2802d110ad88ab09b889f90c8ec8123f20181a 100644
--- a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
+++ b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp
@@ -68,11 +68,11 @@ LayoutRectOutsets LayoutRectOutsets::logicalOutsetsWithFlippedLines(
LayoutUnit LayoutRectOutsets::before(WritingMode writingMode) const {
switch (writingMode) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return m_top;
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return m_left;
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return m_right;
}
ASSERT_NOT_REACHED();
@@ -81,11 +81,11 @@ LayoutUnit LayoutRectOutsets::before(WritingMode writingMode) const {
LayoutUnit LayoutRectOutsets::after(WritingMode writingMode) const {
switch (writingMode) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
return m_bottom;
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
return m_right;
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
return m_left;
}
ASSERT_NOT_REACHED();
@@ -116,13 +116,13 @@ LayoutUnit LayoutRectOutsets::under(WritingMode writingMode) const {
void LayoutRectOutsets::setBefore(WritingMode writingMode, LayoutUnit value) {
switch (writingMode) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
m_top = value;
break;
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
m_left = value;
break;
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
m_right = value;
break;
default:
@@ -133,13 +133,13 @@ void LayoutRectOutsets::setBefore(WritingMode writingMode, LayoutUnit value) {
void LayoutRectOutsets::setAfter(WritingMode writingMode, LayoutUnit value) {
switch (writingMode) {
- case TopToBottomWritingMode:
+ case WritingMode::HorizontalTb:
m_bottom = value;
break;
- case LeftToRightWritingMode:
+ case WritingMode::VerticalLr:
m_right = value;
break;
- case RightToLeftWritingMode:
+ case WritingMode::VerticalRl:
m_left = value;
break;
default:

Powered by Google App Engine
This is Rietveld 408576698