Adding drawable to CRD andorid and iOS gl rendering pipeline.

remoting/client/display/fake_canvas.h

Index: remoting/client/display/fake_canvas.h
diff --git a/remoting/client/display/fake_canvas.h b/remoting/client/display/fake_canvas.h
new file mode 100644
index 0000000000000000000000000000000000000000..5c867aed239bd17e88af44226671f30549c9d008
--- /dev/null
+++ b/remoting/client/display/fake_canvas.h
@@ -0,0 +1,43 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_CLIENT_DISPLAY_FAKE_CANVAS_H_
+#define REMOTING_CLIENT_DISPLAY_FAKE_CANVAS_H_
+
+#include <array>
+
+#include "base/macros.h"
+#include "base/threading/thread_checker.h"
+#include "remoting/client/display/gl_canvas.h"
+#include "remoting/client/display/sys_opengl.h"
+
+namespace remoting {
+
+class FakeCanvas : public Canvas {
+ public:
+  FakeCanvas() {}
+

[joedow, 2017/01/10 00:19:43]

nit: rmeove this newline to squeeze the c'tor and d'tor together

[nicholss, 2017/01/10 21:43:10]

Done.

+  ~FakeCanvas() override {}
+
+  void Clear() override {}
+

[joedow, 2017/01/10 00:19:43]

common practice is to remove the newlines for the overrides and add a comment
like: "// Canvas implementation."

[nicholss, 2017/01/10 21:43:10]

Done.

+  void SetTransformationMatrix(const std::array<float, 9>& matrix) override {}
+
+  void SetViewSize(int width, int height) override {}

[joedow, 2017/01/10 00:19:43]

Since you have a cc file, the impls for all of the methods should go there.  I
haven't seen any cases were we have some empty impls in the header and other
methods in the CC file.

[nicholss, 2017/01/10 16:58:34]

Given this is a test file, does it matter?

[joedow, 2017/01/10 18:49:27]

Test code should beheld to the same (or very similar) standards as product code.
 It is also super easy to do.

[nicholss, 2017/01/10 21:43:10]

Done.

+
+  void DrawTexture(int texture_id,
+                   GLuint texture_handle,
+                   GLuint vertex_buffer,
+                   float alpha_multiplier) override {}
+
+  int GetVersion() const override;
+
+  int GetMaxTextureSize() const override;
+

[joedow, 2017/01/10 00:19:43]

add private:

[nicholss, 2017/01/10 21:43:10]

Done.

+  DISALLOW_COPY_AND_ASSIGN(FakeCanvas);
+};
+
+}  // namespace remoting
+
+#endif  // REMOTING_CLIENT_DISPLAY_FAKE_CANVAS_H_