Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Side by Side Diff: remoting/client/display/gl_renderer.cc

Issue 2591363002: Adding drawable to CRD andorid and iOS gl rendering pipeline. (Closed)
Patch Set: More special casing for Android and windows. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "remoting/client/display/gl_renderer.h" 5 #include "remoting/client/display/gl_renderer.h"
6 6
7 #include <algorithm>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/logging.h" 10 #include "base/logging.h"
9 #include "base/threading/thread_task_runner_handle.h" 11 #include "base/threading/thread_task_runner_handle.h"
12 #include "remoting/client/display/drawable.h"
10 #include "remoting/client/display/gl_canvas.h" 13 #include "remoting/client/display/gl_canvas.h"
11 #include "remoting/client/display/gl_math.h" 14 #include "remoting/client/display/gl_math.h"
12 #include "remoting/client/display/gl_renderer_delegate.h" 15 #include "remoting/client/display/gl_renderer_delegate.h"
13 #include "remoting/client/display/sys_opengl.h" 16 #include "remoting/client/display/sys_opengl.h"
14 #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h" 17 #include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
15 18
16 namespace remoting { 19 namespace remoting {
17 20
21 namespace drawable {
Yuwei 2017/01/09 22:41:54 Make it an anonymous namespace? This is not used o
22
23 struct {
24 bool operator()(base::WeakPtr<Drawable> a, base::WeakPtr<Drawable> b) {
25 return a->GetZIndex() < b->GetZIndex();
26 }
27 } ZOrderComparator;
28
29 } // namespace drawable
30
18 GlRenderer::GlRenderer() : 31 GlRenderer::GlRenderer() :
19 weak_factory_(this) { 32 weak_factory_(this) {
20 weak_ptr_ = weak_factory_.GetWeakPtr(); 33 weak_ptr_ = weak_factory_.GetWeakPtr();
21 thread_checker_.DetachFromThread(); 34 thread_checker_.DetachFromThread();
22 } 35 }
23 36
24 GlRenderer::~GlRenderer() { 37 GlRenderer::~GlRenderer() {
25 } 38 }
26 39
27 void GlRenderer::SetDelegate(base::WeakPtr<GlRendererDelegate> delegate) { 40 void GlRenderer::SetDelegate(base::WeakPtr<GlRendererDelegate> delegate) {
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 pending_done_callbacks_.push(done); 96 pending_done_callbacks_.push(done);
84 RequestRender(); 97 RequestRender();
85 } 98 }
86 99
87 void GlRenderer::OnCursorShapeChanged(const protocol::CursorShapeInfo& shape) { 100 void GlRenderer::OnCursorShapeChanged(const protocol::CursorShapeInfo& shape) {
88 DCHECK(thread_checker_.CalledOnValidThread()); 101 DCHECK(thread_checker_.CalledOnValidThread());
89 cursor_.SetCursorShape(shape); 102 cursor_.SetCursorShape(shape);
90 RequestRender(); 103 RequestRender();
91 } 104 }
92 105
93 void GlRenderer::OnSurfaceCreated(int gl_version) { 106 void GlRenderer::OnSurfaceCreated(std::unique_ptr<Canvas> canvas) {
94 DCHECK(thread_checker_.CalledOnValidThread()); 107 DCHECK(thread_checker_.CalledOnValidThread());
95 #ifndef NDEBUG 108 canvas_ = std::move(canvas);
96 // Set the background clear color to bright green for debugging purposes. 109 for (auto& drawable : drawables_) {
97 glClearColor(0.0f, 1.0f, 0.0f, 1.0f); 110 drawable->SetCanvas(canvas_.get());
98 #else 111 }
99 // Set the background clear color to black.
100 glClearColor(0.0f, 0.0f, 0.0f, 1.0f);
101 #endif
102 canvas_.reset(new GlCanvas(gl_version));
103 desktop_.SetCanvas(canvas_.get());
104 cursor_.SetCanvas(canvas_.get());
105 cursor_feedback_.SetCanvas(canvas_.get());
106 } 112 }
107 113
108 void GlRenderer::OnSurfaceChanged(int view_width, int view_height) { 114 void GlRenderer::OnSurfaceChanged(int view_width, int view_height) {
109 DCHECK(thread_checker_.CalledOnValidThread()); 115 DCHECK(thread_checker_.CalledOnValidThread());
110 if (!canvas_) { 116 if (!canvas_) {
111 LOG(WARNING) << "Trying to set the view size when the canvas is not ready."; 117 LOG(WARNING) << "Trying to set the view size when the canvas is not ready.";
112 return; 118 return;
113 } 119 }
114 canvas_->SetViewSize(view_width, view_height); 120 canvas_->SetViewSize(view_width, view_height);
115 RequestRender(); 121 RequestRender();
(...skipping 14 matching lines...) Expand all
130 void GlRenderer::RequestRender() { 136 void GlRenderer::RequestRender() {
131 DCHECK(thread_checker_.CalledOnValidThread()); 137 DCHECK(thread_checker_.CalledOnValidThread());
132 if (render_scheduled_) { 138 if (render_scheduled_) {
133 return; 139 return;
134 } 140 }
135 base::ThreadTaskRunnerHandle::Get()->PostTask( 141 base::ThreadTaskRunnerHandle::Get()->PostTask(
136 FROM_HERE, base::Bind(&GlRenderer::OnRender, weak_ptr_)); 142 FROM_HERE, base::Bind(&GlRenderer::OnRender, weak_ptr_));
137 render_scheduled_ = true; 143 render_scheduled_ = true;
138 } 144 }
139 145
146 void GlRenderer::AddDrawable(base::WeakPtr<Drawable> drawable) {
147 drawable->SetCanvas(canvas_.get());
148 drawables_.push_back(drawable);
149 std::sort(drawables_.begin(), drawables_.end(), drawable::ZOrderComparator);
150 }
151
140 void GlRenderer::OnRender() { 152 void GlRenderer::OnRender() {
141 DCHECK(thread_checker_.CalledOnValidThread()); 153 DCHECK(thread_checker_.CalledOnValidThread());
142 render_scheduled_ = false; 154 render_scheduled_ = false;
143 if (!delegate_ || !delegate_->CanRenderFrame()) { 155 if (!delegate_ || !delegate_->CanRenderFrame()) {
144 return; 156 return;
145 } 157 }
146 158
147 if (canvas_) { 159 if (canvas_) {
148 glClear(GL_COLOR_BUFFER_BIT); 160 canvas_->Clear();
149 161 // Draw each drawable in order.
150 // Layers will be drawn from bottom to top. 162 for (auto& drawable : drawables_) {
151 desktop_.Draw(); 163 if (drawable->Draw()) {
152 164 RequestRender();
153 // |cursor_feedback_| should be drawn before |cursor_| so that the cursor 165 }
154 // won't be covered by the feedback animation.
155 if (cursor_feedback_.Draw()) {
156 RequestRender();
157 } 166 }
158
159 cursor_.Draw();
160 } 167 }
161 168
162 delegate_->OnFrameRendered(); 169 delegate_->OnFrameRendered();
163 170
164 while (!pending_done_callbacks_.empty()) { 171 while (!pending_done_callbacks_.empty()) {
165 pending_done_callbacks_.front().Run(); 172 pending_done_callbacks_.front().Run();
166 pending_done_callbacks_.pop(); 173 pending_done_callbacks_.pop();
167 } 174 }
168 } 175 }
169 176
177 std::unique_ptr<GlRenderer> GlRenderer::CreateGlRendererWithDesktop() {
178 std::unique_ptr<GlRenderer> renderer(new GlRenderer());
179 renderer->AddDrawable(renderer->desktop_.GetWeakPtr());
180 renderer->AddDrawable(renderer->cursor_.GetWeakPtr());
181 renderer->AddDrawable(renderer->cursor_feedback_.GetWeakPtr());
182 return renderer;
183 }
184
170 } // namespace remoting 185 } // namespace remoting
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698