Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: remoting/client/display/BUILD.gn

Issue 2591363002: Adding drawable to CRD andorid and iOS gl rendering pipeline. (Closed)
Patch Set: Changing a bunch of nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/client/display/canvas.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 source_set("display") { 5 source_set("display") {
6 sources = [ 6 sources = [
7 "canvas.h",
8 "drawable.h",
7 "gl_canvas.cc", 9 "gl_canvas.cc",
8 "gl_canvas.h", 10 "gl_canvas.h",
9 "gl_cursor.cc", 11 "gl_cursor.cc",
10 "gl_cursor.h", 12 "gl_cursor.h",
11 "gl_cursor_feedback.cc", 13 "gl_cursor_feedback.cc",
12 "gl_cursor_feedback.h", 14 "gl_cursor_feedback.h",
13 "gl_cursor_feedback_texture.cc", 15 "gl_cursor_feedback_texture.cc",
14 "gl_cursor_feedback_texture.h", 16 "gl_cursor_feedback_texture.h",
15 "gl_desktop.cc", 17 "gl_desktop.cc",
16 "gl_desktop.h", 18 "gl_desktop.h",
17 "gl_helpers.cc", 19 "gl_helpers.cc",
18 "gl_helpers.h", 20 "gl_helpers.h",
19 "gl_math.cc", 21 "gl_math.cc",
20 "gl_math.h", 22 "gl_math.h",
21 "gl_render_layer.cc", 23 "gl_render_layer.cc",
22 "gl_render_layer.h", 24 "gl_render_layer.h",
23 "gl_renderer.cc", 25 "gl_renderer.cc",
24 "gl_renderer.h", 26 "gl_renderer.h",
27 "sys_opengl.h",
25 ] 28 ]
26 29
27 deps = [ 30 deps = [
28 "//remoting/proto", 31 "//remoting/proto",
29 "//third_party/libyuv", 32 "//third_party/libyuv",
30 "//third_party/webrtc/base:rtc_base", 33 "//third_party/webrtc/base:rtc_base",
31 ] 34 ]
32 35
33 configs += [ "//third_party/khronos:khronos_headers" ] 36 public_configs = [ "//third_party/khronos:khronos_headers" ]
37
38 if (is_android) {
39 libs = [
40 "GLESv2",
41 "OpenSLES",
Yuwei 2017/01/10 19:36:10 OpenSLES shouldn't be included here. It's for Andr
nicholss 2017/01/10 21:43:10 Done.
42 ]
43 }
34 44
35 if (is_linux) { 45 if (is_linux) {
36 libs = [ "GL" ] 46 libs = [ "GL" ]
37 } 47 }
38 48
39 if (is_mac) { 49 if (is_mac) {
40 libs = [ "OpenGL.framework" ] 50 libs = [ "OpenGL.framework" ]
41 } 51 }
42 52
43 if (is_ios) { 53 if (is_ios) {
44 libs = [ 54 libs = [
45 "GLKit.framework", 55 "GLKit.framework",
46 "OpenGLES.framework", 56 "OpenGLES.framework",
47 ] 57 ]
48 } 58 }
49 59
50 if (is_win) { 60 if (is_win) {
51 deps += [ "//third_party/angle:libGLESv2" ] 61 deps += [ "//third_party/angle:libGLESv2" ]
52 } 62 }
53 } 63 }
54 64
55 source_set("unit_tests") { 65 if (is_win) {
56 testonly = true 66 group("unit_tests") {
Yuwei 2017/01/10 19:36:10 Please add the comment about the ANGLE GLESv2 issu
nicholss 2017/01/10 21:43:10 Done.
67 deps = []
68 }
69 } else {
70 source_set("unit_tests") {
71 testonly = true
57 72
58 sources = [ 73 sources = [
59 "gl_renderer_unittest.cc", 74 "fake_canvas.cc",
60 ] 75 "fake_canvas.h",
76 "gl_renderer_unittest.cc",
77 ]
61 78
62 configs += [ 79 configs += [
63 "//remoting/build/config:version", 80 "//remoting/build/config:version",
64 "//remoting/build/config:enable_webrtc_remoting_client", 81 "//remoting/build/config:enable_webrtc_remoting_client",
65 ] 82 ]
66 83
67 deps = [ 84 deps = [
68 ":display", 85 ":display",
69 "//remoting/proto", 86 "//remoting/proto",
70 "//testing/gmock", 87 "//testing/gmock",
71 "//testing/gtest", 88 "//testing/gtest",
72 "//third_party/webrtc/base:rtc_base", 89 "//third_party/webrtc/base:rtc_base",
73 ] 90 ]
74
75 if (is_win) {
76 # Windows clang builder fails to link the test binary with ANGLE GLESv2.
77 # crbug.com/642027
78 sources -= [ "gl_renderer_unittest.cc" ]
79 deps -= [ ":display" ]
80 } 91 }
81 } 92 }
OLDNEW
« no previous file with comments | « no previous file | remoting/client/display/canvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698