ui/views/view.h - Issue 2591323002: [views] Changes iteration over |children_| to use range-based for loops (reland)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view.h

Issue 2591323002: [views] Changes iteration over |children_| to use range-based for loops (reland) (Closed)

Patch Set: [views] Changes iteration over |children_| to use range-based for loops (DCHECKs) Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/view.h

diff --git a/ui/views/view.h b/ui/views/view.h

index a6811afca8a5c084b0d81d5ab375e483cc46c006..8a296a99b813c315b1c960d07b97d0da636b6d1b 100644

--- a/ui/views/view.h

+++ b/ui/views/view.h

@@ -1466,6 +1466,12 @@ class VIEWS_EXPORT View : public ui::LayerDelegate,

// This view's children.

Views children_;

+#if DCHECK_IS_ON()

+ // True while iterating over |children_|. Used to detect and DCHECK when

+ // |children_| is mutated during iteration.

+ mutable bool iterating_;

+#endif

// Size and disposition ------------------------------------------------------

// This View's bounds in the parent coordinate system.

« no previous file with comments | « no previous file | ui/views/view.cc » ('j') | ui/views/view.cc » ('J')