Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html

Issue 2591233004: Provide detailed information on the test failure (Closed)
Patch Set: Addressing feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
index 7fbace2f44c285caef3646b40f9dd735d3c3e7a0..b2ba5789716899219ffda03396059f8468727661 100644
--- a/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
+++ b/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html
@@ -27,8 +27,8 @@
should(function () { var foo = 0; }).throw('ReferenceError');
should(3 > 5, '3 < 5').beTrue();
should(true).beFalse();
- should(1).beEqualTo(2)
- should(1).notBeEqualTo(1)
+ should(1, 'one').beEqualTo(2);
Raymond Toy 2016/12/21 21:57:37 I meant in addition to the case without a descript
hongchan 2016/12/21 22:43:55 Done.
+ should(1).notBeEqualTo(1);
should(typeof 3.141592, 'typeof 3.141592').beEqualTo('string');
should(1).beGreaterThan(2);
should(1).beGreaterThanOrEqualTo(2);
@@ -49,6 +49,7 @@
task.describe('Testing numerical assertion failures.');
should(0).beCloseTo(0.1, { threshold: 0 });
+ should(0, 'zero').beCloseTo(0.1, { threshold: 0 });
Raymond Toy 2016/12/21 21:57:37 Use some better, more typical description. "zero"
hongchan 2016/12/21 22:43:55 Done.
should([1, 8, 11, 18, 6, 5, 5, 5, 123, 49]).beConstantValueOf(5);
should([1, 8, 11, 18, 6, 5, 5, 5, 123, 49])
.beEqualToArray([1, 8, 10, 18, 6, 5, 6, 5, 123, 48]);

Powered by Google App Engine
This is Rietveld 408576698