Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 259123002: Include icu.isolate from ui_unittests.isolate (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
csharp, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Include icu.isolate from ui_unittests.isolate ui_unittests needs the ICU data file. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/ui_unittests.isolate View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Xianzhu
6 years, 7 months ago (2014-04-28 20:54:32 UTC) #1
M-A Ruel
lgtm
6 years, 7 months ago (2014-04-28 20:55:02 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 20:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259123002/1
6 years, 7 months ago (2014-04-28 20:58:41 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:03:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 21:03:28 UTC) #6
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 21:08:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259123002/1
6 years, 7 months ago (2014-04-28 21:09:28 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:56:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 21:56:41 UTC) #10
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 21:57:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259123002/1
6 years, 7 months ago (2014-04-28 21:58:33 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:11:10 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 7 months ago (2014-04-28 22:11:10 UTC) #14
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 22:11:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259123002/1
6 years, 7 months ago (2014-04-28 22:12:52 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:51:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 7 months ago (2014-04-28 22:51:03 UTC) #18
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-04-28 22:54:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/259123002/1
6 years, 7 months ago (2014-04-28 22:55:03 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 02:31:20 UTC) #21
Message was sent while issue was closed. 
Change committed as 266742

Powered by Google App Engine
This is Rietveld 408576698