net/tools/quic/quic_http_response_cache.cc - Issue 2591143003: Add QuicStrCat.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_http_response_cache.cc

Issue 2591143003: Add QuicStrCat. (Closed)

Patch Set: correct quic_client_bin.cc Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/quic_http_response_cache.cc

diff --git a/net/tools/quic/quic_http_response_cache.cc b/net/tools/quic/quic_http_response_cache.cc

index bc6c819f5249edd34b41407fb565b7b89ec4d4f0..47a5084897c2385822b65ea8d8d74a6c1e7fe0bb 100644

--- a/net/tools/quic/quic_http_response_cache.cc

+++ b/net/tools/quic/quic_http_response_cache.cc

@@ -338,7 +338,7 @@ void QuicHttpResponseCache::MaybeAddServerPushResources(

StringPiece request_host,

StringPiece request_path,

std::list<ServerPushInfo> push_resources) {

- string request_url = GetKey(request_host, request_path);

+ string request_url = QuicStrCat(request_host, request_path);

Ryan Hamilton 2016/12/22 18:17:30 I think we should use GetKey here (and in the inte

for (const auto& push_resource : push_resources) {

if (PushResourceExistsInCache(request_url, push_resource)) {