Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2598)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2591143003: Add QuicStrCat. (Closed)
Patch Set: correct quic_client_bin.cc Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index f3c7226b22f7e91a3e42f1d738bdec671a7af7a3..6470ebd4042ff4135a2958d7167ddf1902a63e7b 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -1205,9 +1205,8 @@ TEST_P(BufferedPacketStoreTest, ProcessNonChloPacketsUptoLimitAndProcessChlo) {
.Times(1);
for (size_t i = 1; i <= kDefaultMaxUndecryptablePackets + 1; ++i) {
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(i + 1),
- PACKET_8BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER,
- kDefaultPathId,
+ QuicStrCat("data packet ", i + 1), PACKET_8BYTE_CONNECTION_ID,
+ PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/i + 1);
}
EXPECT_EQ(0u, dispatcher_->session_map().size())
@@ -1259,7 +1258,7 @@ TEST_P(BufferedPacketStoreTest,
}
}
ProcessPacket(client_address, conn_id, true, false,
- "data packet on connection " + IntToString(i),
+ QuicStrCat("data packet on connection ", i),
PACKET_8BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER,
kDefaultPathId,
/*packet_number=*/2);
@@ -1334,7 +1333,7 @@ TEST_P(BufferedPacketStoreTest, ReceiveRetransmittedCHLO) {
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId conn_id = 1;
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(2), PACKET_8BYTE_CONNECTION_ID,
+ QuicStrCat("data packet ", 2), PACKET_8BYTE_CONNECTION_ID,
PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/2);
@@ -1369,7 +1368,7 @@ TEST_P(BufferedPacketStoreTest, ReceiveCHLOAfterExpiration) {
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId conn_id = 1;
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(2), PACKET_8BYTE_CONNECTION_ID,
+ QuicStrCat("data packet ", 2), PACKET_8BYTE_CONNECTION_ID,
PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/2);

Powered by Google App Engine
This is Rietveld 408576698