Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: net/tools/quic/quic_dispatcher_test.cc

Issue 2591143003: Add QuicStrCat. (Closed)
Patch Set: sync Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_client_bin.cc ('k') | net/tools/quic/quic_http_response_cache_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher_test.cc
diff --git a/net/tools/quic/quic_dispatcher_test.cc b/net/tools/quic/quic_dispatcher_test.cc
index f1e7853f929584c131eed00eba9a6eaa64b044b4..cf6723c4ee65ccc7cf6a47a887bbe2f66571a049 100644
--- a/net/tools/quic/quic_dispatcher_test.cc
+++ b/net/tools/quic/quic_dispatcher_test.cc
@@ -16,6 +16,7 @@
#include "net/quic/core/quic_crypto_stream.h"
#include "net/quic/core/quic_flags.h"
#include "net/quic/core/quic_utils.h"
+#include "net/quic/platform/api/quic_str_cat.h"
#include "net/quic/test_tools/crypto_test_utils.h"
#include "net/quic/test_tools/fake_proof_source.h"
#include "net/quic/test_tools/quic_buffered_packet_store_peer.h"
@@ -1207,9 +1208,8 @@ TEST_P(BufferedPacketStoreTest, ProcessNonChloPacketsUptoLimitAndProcessChlo) {
.Times(1);
for (size_t i = 1; i <= kDefaultMaxUndecryptablePackets + 1; ++i) {
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(i + 1),
- PACKET_8BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER,
- kDefaultPathId,
+ QuicStrCat("data packet ", i + 1), PACKET_8BYTE_CONNECTION_ID,
+ PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/i + 1);
}
EXPECT_EQ(0u, dispatcher_->session_map().size())
@@ -1262,7 +1262,7 @@ TEST_P(BufferedPacketStoreTest,
}
}
ProcessPacket(client_address, conn_id, true, false,
- "data packet on connection " + IntToString(i),
+ QuicStrCat("data packet on connection ", i),
PACKET_8BYTE_CONNECTION_ID, PACKET_6BYTE_PACKET_NUMBER,
kDefaultPathId,
/*packet_number=*/2);
@@ -1338,7 +1338,7 @@ TEST_P(BufferedPacketStoreTest, ReceiveRetransmittedCHLO) {
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId conn_id = 1;
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(2), PACKET_8BYTE_CONNECTION_ID,
+ QuicStrCat("data packet ", 2), PACKET_8BYTE_CONNECTION_ID,
PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/2);
@@ -1373,7 +1373,7 @@ TEST_P(BufferedPacketStoreTest, ReceiveCHLOAfterExpiration) {
server_address_ = QuicSocketAddress(QuicIpAddress::Any4(), 5);
QuicConnectionId conn_id = 1;
ProcessPacket(client_address, conn_id, true, false,
- "data packet " + IntToString(2), PACKET_8BYTE_CONNECTION_ID,
+ QuicStrCat("data packet ", 2), PACKET_8BYTE_CONNECTION_ID,
PACKET_6BYTE_PACKET_NUMBER, kDefaultPathId,
/*packet_number=*/2);
« no previous file with comments | « net/tools/quic/quic_client_bin.cc ('k') | net/tools/quic/quic_http_response_cache_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698