net/quic/platform/impl/quic_str_cat_impl.h - Issue 2591143003: Add QuicStrCat.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/quic/platform/impl/quic_str_cat_impl.h

Issue 2591143003: Add QuicStrCat. (Closed)

Patch Set: correct quic_client_bin.cc Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_QUIC_PLATFORM_IMPL_QUIC_STR_CAT_IMPL_H_

	6 #define NET_QUIC_PLATFORM_IMPL_QUIC_STR_CAT_IMPL_H_

	7

	8 #include <string>

	9

	10 namespace net {

	11

	12 template <typename... Args>

	13 inline std::string QuicStrCatImpl(const Args&... args) {

	14 std::ostringstream oss;
	Ryan Hamilton 2016/12/22 18:17:30 nit: I suspect you need to #include something here nit: I suspect you need to #include something here.
	15 int dummy[] = {1, (oss << args, 0)...};

	16 static_cast<void>(dummy);

	17 return oss.str();

	18 }

	19

	20 } // namespace net

	21

	22 #endif // NET_QUIC_PLATFORM_IMPL_QUIC_STR_CAT_IMPL_H_

OLD	NEW